Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align logback's behavior with log4j2 when getting a logger that doesn't exist #21292

Closed
mbhave opened this issue May 1, 2020 · 0 comments
Closed

Align logback's behavior with log4j2 when getting a logger that doesn't exist #21292

mbhave opened this issue May 1, 2020 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
2.3.0

Comments

@mbhave
Copy link
Contributor

mbhave commented May 1, 2020 •
edited

Currently, if a GET request to the /loggers endpoint is made for a logger that doesn't exist, logback will create the logger. Log4j2 returns a 404. It would be nice to align the two. Logback has a exists() method which we can check before returning the logger configuration. This would also prevent a GET request from having a side-effect.
@mbhave mbhave added the type: enhancement A general enhancement label May 1, 2020
@mbhave mbhave added this to the 2.3.x milestone May 1, 2020
@mbhave mbhave closed this as completed in 7634901 May 6, 2020
@mbhave mbhave modified the milestones: 2.3.x, 2.3.0 May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@mbhave