Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JarFiles are being left open #21126

Closed
philwebb opened this issue Apr 25, 2020 · 0 comments
Closed

JarFiles are being left open #21126

philwebb opened this issue Apr 25, 2020 · 0 comments
Labels
type: bug A general bug
Milestone
2.2.7

Comments

@philwebb
Copy link
Member

Windows CI is failing following the fix for #17796 but only on 2.2.x. I suspect this may be a result of the new fix clashing with the older fix for #17127
@philwebb philwebb added type: blocker An issue that is blocking us from releasing type: bug A general bug labels Apr 25, 2020
@philwebb philwebb added this to the 2.2.x milestone Apr 25, 2020
This was referenced Apr 25, 2020
Closed
Closed
philwebb added a commit that referenced this issue Apr 25, 2020
@philwebb
Attempt to prevent JarFiles from being left open
7c6e912 
Update `JarFile` so that `super.close()` is called early so that the
file is not left open. Since we re-implement `JarFile` methods to work
directly on the underlying `RandomAccessDataFile`, it should be safe
to close immediately.

See gh-21126
philwebb added a commit that referenced this issue Apr 26, 2020
@philwebb
Attempt to prevent JarFiles from being left open
7d53f7d 
Update `JarFile` to also call `super.close()` early for nested jars.

See gh-21126
@philwebb philwebb mentioned this issue Apr 28, 2020
Closed
@philwebb philwebb removed the type: blocker An issue that is blocking us from releasing label Apr 28, 2020
@philwebb philwebb modified the milestones: 2.2.x, 2.2.7 Apr 28, 2020
@philwebb philwebb mentioned this issue Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.2.7
Development

No branches or pull requests
1 participant
@philwebb