Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version number from author section of the documentation #20934

Closed
philwebb opened this issue Apr 13, 2020 · 2 comments
Closed

Remove version number from author section of the documentation #20934

philwebb opened this issue Apr 13, 2020 · 2 comments
Labels
type: documentation A documentation update
Milestone

Comments

@philwebb
Copy link
Member

I'm not sure if this is related to the new docs style sheet or something else, but we now have a version number in the authors list:

Screen Shot 2020-04-13 at 4 25 45 PM

vs

Screen Shot 2020-04-13 at 4 25 50 PM

@philwebb philwebb added this to the 2.3.x milestone Apr 13, 2020
@philwebb philwebb added the type: documentation A documentation update label Apr 13, 2020
@mbhave mbhave changed the title Author secion contain version number Author section contain version number Apr 13, 2020
@mbhave
Copy link
Contributor

mbhave commented Apr 13, 2020

Depending on the fix, there might be some overlap with #20896.

@wilkinsona
Copy link
Member

I don't think it's related to the new docs stylesheet as it's been that was since 2.3.0.M1. I believe it's happening because the Gradle Asciidoctor plugin configures the revnumber attribute by default.

When revnumber is set or inferred from the source document, it's included in the byline. In other words, we're seeing Asciidoctor's standard behaviour here. If we don't like it, we can get rid of it by explicitly setting the revnumber attribute to null.

@mbhave mbhave closed this as completed in 376098d May 12, 2020
@mbhave mbhave modified the milestones: 2.3.x, 2.3.0 May 12, 2020
@wilkinsona wilkinsona changed the title Author section contain version number Remove version number from author section of the documentation May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants