Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more context to the Kubernetes container lifecycle documentation #20932

Closed
ryanjbaxter opened this issue Apr 13, 2020 · 1 comment
Closed

Add more context to the Kubernetes container lifecycle documentation #20932

ryanjbaxter opened this issue Apr 13, 2020 · 1 comment
Labels
type: documentation A documentation update
Milestone
2.3.0

Comments

@ryanjbaxter
Copy link

The YAML in Kubernetes Container Lifecycle documentation should provide more context about where the user should place this YAML

https://docs.spring.io/spring-boot/docs/2.3.0.M4/reference/html/deployment.html#cloud-deployment-kubernetes-container-lifecycle

For a novice they might now know that this belongs in the podspec of the deployment yaml
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 13, 2020
@scottfrederick scottfrederick added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 13, 2020
@scottfrederick scottfrederick added this to the 2.3.x milestone Apr 13, 2020
@scottfrederick
Copy link
Contributor

See https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/#define-poststart-and-prestop-handlers

@scottfrederick scottfrederick changed the title Kubernetes Container Lifecycle Documentation Needs More Context Kubernetes container lifecycle documentation needs more context Apr 13, 2020
@wilkinsona wilkinsona changed the title Kubernetes container lifecycle documentation needs more context Add more context to the Kubernetes container lifecycle documentation Apr 30, 2020
@mbhave mbhave closed this as completed in 7468f57 May 12, 2020
@mbhave mbhave modified the milestones: 2.3.x, 2.3.0 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
4 participants
@scottfrederick @ryanjbaxter @mbhave @spring-projects-issues