Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default for spring.kafka.listener.missing-topics-fatal is no longer aligned with Spring Kafka's default #20828

Closed
garyrussell opened this issue Apr 3, 2020 · 4 comments
Closed

Default for spring.kafka.listener.missing-topics-fatal is no longer aligned with Spring Kafka's default #20828

garyrussell opened this issue Apr 3, 2020 · 4 comments
Labels
status: superseded An issue that has been superseded by another type: bug A general bug

Comments

@garyrussell
Copy link
Contributor

(Also Boot 2.2).

We changed the default in spring-kafka to false in 2.3.4.

This property was added in S-K 2.2 with default true but this caused too many problems for the community.

https://docs.spring.io/spring-kafka/docs/2.4.5.RELEASE/reference/html/#configuration-changes
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2020
@wilkinsona wilkinsona changed the title Change Default for KafkaProperties.missingTopicsFatal to false Default for spring.kafka.listener.missing-topics-fatal is no longer aligned with Spring Kafka's default Apr 6, 2020
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 6, 2020
@wilkinsona wilkinsona added this to the 2.2.x milestone Apr 6, 2020
@dhirenmathur
Copy link

Hi, I'm looking to start contributing to OSS and this looks like a good place to start, is this up for grabs?

@snicoll
Copy link
Member

snicoll commented Apr 10, 2020

Yes. We’d need a test to assert the default is consistent. Thanks for the offer!

@dhirenmathur
Copy link

Thanks @snicoll , I'll start working on it. 👍

@dhirenmathur dhirenmathur mentioned this issue Apr 11, 2020
Closed
@snicoll
Copy link
Member

snicoll commented Apr 11, 2020

Closing in favour of PR #20917

@snicoll snicoll closed this as completed Apr 11, 2020
@snicoll snicoll removed this from the 2.2.x milestone Apr 11, 2020
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@garyrussell @snicoll @wilkinsona @spring-projects-issues @dhirenmathur