Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply multiple docker image tags when publishing images #20560

Closed
skuzzle opened this issue Mar 18, 2020 · 4 comments
Closed

Apply multiple docker image tags when publishing images #20560

skuzzle opened this issue Mar 18, 2020 · 4 comments
Labels
status: superseded An issue that has been superseded by another theme: kubernetes type: enhancement A general enhancement

Comments

@skuzzle
Copy link

skuzzle commented Mar 18, 2020

As of #19698 spring boot has native support for building docker images which is a great approach to further simplify the build process.

When publishing docker images a common approach is to provide multiple tags per image. Probably most common is to publish the actual version along with an additional latest tag. I'd love to see Spring Boot support multiple tags per image (that would also simplify migrating from the also great jib plugin which already supports multiple tags)

@skuzzle skuzzle changed the title Add support for multiple docker tags Add support for multiple docker image tags Mar 18, 2020
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 18, 2020
@scottfrederick
Copy link
Contributor

scottfrederick commented Mar 18, 2020

This is a good idea. As you can see in #19698, we haven't yet gotten to publishing generated docker images to a repository via the Spring Boot build tool plugins. This is a lower-priority feature as there are plenty of ways to do this with other tools like docker CLI, and publishing images from the Spring Boot build tool plugins might not make it into 2.3.0.RELEASE. I'll tag this as a useful feature of publishing if/when we do get to it.

@scottfrederick scottfrederick changed the title Add support for multiple docker image tags Apply multiple docker image tags when publishing images Mar 18, 2020
@scottfrederick scottfrederick added theme: kubernetes type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 18, 2020
@scottfrederick scottfrederick added this to the 2.3.x milestone Mar 18, 2020
@philwebb philwebb mentioned this issue Mar 18, 2020
14 tasks
@philwebb

This comment has been minimized.

@philwebb philwebb modified the milestones: 2.3.x, 2.x Apr 17, 2020
@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Apr 17, 2020
@philwebb philwebb modified the milestones: 2.x, 2.4.x Jun 5, 2020
@philwebb philwebb removed the status: blocked An issue that's blocked on an external project change label Oct 19, 2020
@philwebb philwebb modified the milestones: 2.4.x, 2.5.x Oct 19, 2020
@philwebb philwebb added the status: pending-design-work Needs design work before any code can be developed label Mar 19, 2021
@philwebb philwebb modified the milestones: 2.5.x, 2.6.x Mar 19, 2021
@thadc23
Copy link

thadc23 commented May 8, 2021

Now that the spring-boot-maven-plugin supports pushing native images to remote repos, should this be revisited? It would be very beneficial to be able to tag the build with the commit SHA and latest at the same time. If so, I'm happy to give it a shot.

@scottfrederick
Copy link
Contributor

Closing in favor of #27613

@scottfrederick scottfrederick added status: superseded An issue that has been superseded by another and removed status: pending-design-work Needs design work before any code can be developed labels Aug 16, 2021
@scottfrederick scottfrederick removed this from the 2.6.x milestone Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another theme: kubernetes type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants