Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify non-public nature of Boot’s own @ConfigurationProperties classes and multi-DataSource example #19199

Closed
wilkinsona opened this issue Nov 30, 2019 · 0 comments
Closed

Clarify non-public nature of Boot’s own @ConfigurationProperties classes and multi-DataSource example #19199

wilkinsona opened this issue Nov 30, 2019 · 0 comments
Assignees
@snicoll
Labels
type: documentation A documentation update
Milestone
2.1.12

Comments

@wilkinsona
Copy link
Member

See #19194 (comment). We need to clarify exactly what is meant by @ConfigurationProperties classes not being part of the public API. The docs are contradictory at the moment as the example for configuring two DataSources uses the DataSourceProperties type and calls a method (initializeDataSourceBuilder) on it.
@wilkinsona wilkinsona added type: documentation A documentation update for: team-attention An issue we'd like other members of the team to review labels Nov 30, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Nov 30, 2019
@wilkinsona wilkinsona mentioned this issue Nov 30, 2019
Closed
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Dec 11, 2019
@bclozel bclozel mentioned this issue Dec 17, 2019
Closed
@snicoll snicoll self-assigned this Dec 24, 2019
@snicoll snicoll modified the milestones: 2.1.x, 2.1.12 Dec 24, 2019
This was referenced Dec 24, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.1.12
Development

No branches or pull requests
3 participants
@snicoll @philwebb @wilkinsona