Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CachingOperationInvoker#apply #19089

Closed
snicoll opened this issue Nov 21, 2019 · 5 comments
Closed

Deprecate CachingOperationInvoker#apply #19089

snicoll opened this issue Nov 21, 2019 · 5 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.3.0.M1

Comments

@snicoll
Copy link
Member

snicoll commented Nov 21, 2019

Unless I am missing the context CachingOperationInvoker#apply isn't called anywhere and I fail to see why we'd open such contract for public use.

If that's correct, we should probably deprecate it.
@snicoll snicoll added the type: task A general task label Nov 21, 2019
@snicoll snicoll added this to the 2.3.0.M1 milestone Nov 21, 2019
@dreis2211
Copy link
Contributor

Maybe because the constructor of CachingOperationInvoker isn't public? Was wondering about it when working on #18961 as well.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Nov 21, 2019
@wilkinsona
Copy link
Member

We'll deprecate it in 2.3.

@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Nov 22, 2019
@dreis2211
Copy link
Contributor

dreis2211 commented Nov 22, 2019 •
edited

I'd be happy to contribute. Just deprecating it and not changing anything else then (e.g. by making the constructor public)?

@wilkinsona
Copy link
Member

Other than in tests, I can't see anything that requires the class to be public. It's tempting to deprecate the whole thing with a view to making it package-private in 2.4. I wonder if Spring Cloud uses it for some reason, @spencergibb?

@snicoll snicoll self-assigned this Jan 16, 2020
@snicoll
Copy link
Member Author

snicoll commented Jan 16, 2020

I've deprecated the method with a note. @spencergibb if Spring Cloud is using it after all, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.3.0.M1
Development

No branches or pull requests
3 participants
@snicoll @wilkinsona @dreis2211