Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Spring Framework 5.2.2 #19076

Closed
snicoll opened this issue Nov 20, 2019 · 8 comments
Closed

Upgrade to Spring Framework 5.2.2 #19076

snicoll opened this issue Nov 20, 2019 · 8 comments
Labels
status: superseded An issue that has been superseded by another type: task A general task
Milestone
2.3.0.M1

Comments

@snicoll
Copy link
Member

snicoll commented Nov 20, 2019

No description provided.

@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label Nov 20, 2019
@snicoll snicoll added this to the 2.3.0.M1 milestone Nov 20, 2019
snicoll added a commit that referenced this issue Nov 20, 2019
@snicoll
Start building against Spring Framework 5.2.2 snapshots
744f9f9 
See gh-19076
@dreis2211
Copy link
Contributor

dreis2211 commented Nov 21, 2019 •
edited

The current snapshot seems to break the following test:

  • DefaultErrorWebExceptionHandlerIntegrationTests.responseCommitted

I couldn't find the root cause yet unfortunately, but apparently it's hitting the timeout exception instead of the expected one. It seems that it hangs now somewhere.

@snicoll
Copy link
Member Author

snicoll commented Nov 21, 2019

Thanks @dreis2211, we've started investigating that this morning.

@dreis2211
Copy link
Contributor

dreis2211 commented Nov 21, 2019 •
edited

Given that there is a new log entry

2019-11-21 09:30:24.537 ERROR   --- [     parallel-1] reactor.core.scheduler.Schedulers        : Scheduler worker in group main failed with an uncaught exception

I suspect spring-projects/spring-framework@5d2fc2f to cause the change in behaviour, but I'm not sure.

@bclozel bclozel mentioned this issue Nov 21, 2019
Closed
@bclozel
Copy link
Member

bclozel commented Nov 21, 2019

See #19083

@bclozel
Copy link
Member

bclozel commented Nov 22, 2019

#19083 is now closed, closing this issue as a result.

@bclozel bclozel closed this as completed Nov 22, 2019
@dreis2211
Copy link
Contributor

Forgive me the question, but isn't the upgrade still pending? Boot is just building against the current snapshots at the moment.

@bclozel bclozel reopened this Nov 22, 2019
@bclozel
Copy link
Member

bclozel commented Nov 22, 2019

You're right 🤦‍♂ - we'll close it with the actual GA. Thanks again @dreis2211 !

@bclozel bclozel closed this as completed in 48bf478 Dec 3, 2019
@wilkinsona
Copy link
Member

Superseded by #19534.

@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another type: task A general task and removed type: dependency-upgrade A dependency upgrade labels Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
2.3.0.M1
Development

No branches or pull requests
4 participants
@bclozel @snicoll @wilkinsona @dreis2211