Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in SpringBootExstension class #18997

Closed
Jonatha1983 opened this issue Nov 12, 2019 · 2 comments
Closed

Bug in SpringBootExstension class #18997

Jonatha1983 opened this issue Nov 12, 2019 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@Jonatha1983
Copy link

Hi

Seems like you got a bug in the SpringBootExstension class:

private static String getArchiveBaseName(AbstractArchiveTask task) {
		try {
			Method method = findMethod(task.getClass(), "getArchiveBaseName");
			if (method != null) {
				return (String) method.invoke(task);
			}
		}

The method getArchiveBaseName return a Property instance.

So I suggest to change to change it to:

 private static String getArchiveBaseName(AbstractArchiveTask task) {
        try {
            Method method = findMethod(task.getClass(), "getArchiveBaseName");
            if (method != null) {
                Property<String> property = (Property<String>) method.invoke(task)
                return property.get()
            }

Thanks

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 12, 2019
@wilkinsona
Copy link
Member

wilkinsona commented Nov 12, 2019

Well spotted. Thank you. I have this on a branch where I've been doing some work with Gradle 6 but need to apply it to 2.2.x and master.

@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 12, 2019
@wilkinsona
Copy link
Member

As it hasn't been released yet, I've re-opened #18663 to make the necessary change.

@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed type: task A general task labels Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

3 participants