Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationContextRequestMatcher can use the wrong ApplicationContext #18012

Closed
philwebb opened this issue Aug 30, 2019 · 1 comment
Closed

ApplicationContextRequestMatcher can use the wrong ApplicationContext #18012

philwebb opened this issue Aug 30, 2019 · 1 comment
Labels
type: bug A general bug
Milestone
2.1.8

Comments

@philwebb
Copy link
Member

Discovered during #17912

ApplicationContextRequestMatcher uses WebApplicationContextUtils.getRequiredWebApplicationContext(request.getServletContext()) to obtain the application context and caches the supplier. If there is a management server running on a different port, it's possible for the wrong context to be used depending on who makes the first request.
@philwebb philwebb added the type: bug A general bug label Aug 30, 2019
@philwebb philwebb added this to the 2.1.x milestone Aug 30, 2019
@Sauhardstark

This comment has been minimized.

Sign in to view
@philwebb philwebb mentioned this issue Aug 30, 2019
Closed
philwebb added a commit that referenced this issue Aug 30, 2019
@philwebb
Fix EndpointRequest ignore logic
db26d9d 
Fixup ignore logic in `EndpointRequest`.

See gh-18012
pull bot pushed a commit to scope-demo/spring-boot that referenced this issue Aug 30, 2019
@philwebb @pull
Fix EndpointRequest ignore logic
1a12e0d 
Fixup ignore logic in `EndpointRequest`.

See spring-projectsgh-18012
@philwebb philwebb modified the milestones: 2.1.x, 2.1.8 Aug 31, 2019
philwebb added a commit that referenced this issue Aug 31, 2019
@philwebb
Fix chackstyle violations in test
dc0a642 
See gh-18012
@philwebb philwebb mentioned this issue Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.1.8
Development

No branches or pull requests
2 participants
@philwebb @Sauhardstark