You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consider making it an ObjectProvider and getIfUnique()
@garyrussell looking at the conversation I am not sure sure about that. If someone creates their own bean, we should not apply our configuration to it so setting the autoStartup flag on the @Primary one feels wrong to me.
Looking at the discussion on the first post, it looks like they want to add something and still use the defaults provided by @EnableKafkaStreams. Regardless of wether we want to do that or not, we should not configure something that the user has configured IMO.
We already have a @ConditionalOnBean(name = KafkaStreamsDefaultConfiguration.DEFAULT_STREAMS_BUILDER_BEAN_NAME) at class level. I believe we should apply the same logic there.
snicoll
changed the title
Consider making Kafka Streams auto-configuration parameter an ObjectProvider
Kafka Streams auto-configuration should only configure default streams builder
Mar 27, 2019
KafkaStreamsAnnotationDrivenConfiguration
This blows up if there are multiple factory beans. Consider making it an
ObjectProvider
andgetIfUnique()
(or resolve in some other way).2 people have reported this issue recently on Stack Overflow and today.
The text was updated successfully, but these errors were encountered: