Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AprLifecycleListener is configured even though Tomcat's native library is not available #16040

Closed
wilkinsona opened this issue Feb 26, 2019 · 1 comment
Assignees
Labels
type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

When an app using Tomcat starts up, due to the presence of the AprLifecycleListener, it logs the following info message:

2019-02-26 13:59:29.961  INFO 67175 --- [           main] o.a.catalina.core.AprLifecycleListener   : The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: …

I think, and it's only an educated guess, that this is causing some confusion and leading people to believe that Tomcat isn't going to perform well in production. The listener was added in 5f57578. I wonder if there's a way to be a bit smarter about when we add it and only add it when it will be used.

@wilkinsona wilkinsona added this to the 2.2.x milestone Feb 26, 2019
@wilkinsona wilkinsona added type: task A general task for: team-attention An issue we'd like other members of the team to review labels Feb 26, 2019
@wilkinsona
Copy link
Member Author

I think we could create an instance, call AprLifecycleListener.isAvailable() (it's a static method but creating the instance has a side-effect that affects the result of isAvailable()) and then only add the listener if the result is true.

@philwebb philwebb modified the milestones: 2.2.x, 2.1.x Mar 6, 2019
@wilkinsona wilkinsona changed the title Reconsider always configuring Tomcat with the AprLifecycleListener AprLifecycleListener is configured even though Tomcat's native library is not available Mar 6, 2019
@wilkinsona wilkinsona added type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review type: task A general task labels Mar 6, 2019
@wilkinsona wilkinsona self-assigned this Apr 2, 2019
@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.4 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants