Skip to content

Incremental compilation does not keep metadata for inner classes #10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Nov 2, 2017 · 2 comments
Closed

Incremental compilation does not keep metadata for inner classes #10886

snicoll opened this issue Nov 2, 2017 · 2 comments
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
2.2.11

Comments

@snicoll
Copy link
Member

snicoll commented Nov 2, 2017

When the annotation processor runs incrementally, it doesn't keep the properties that are in a nested group (i.e. NestedConfigurationProperty).

When working in the module where the @ConfigurationProperties object is defined, such properties became all the sudden invalid.
@snicoll snicoll self-assigned this Nov 2, 2017
@philwebb philwebb added this to the 1.5.x milestone Mar 21, 2018
@snicoll snicoll modified the milestones: 1.5.x, 2.0.x May 28, 2018
@snicoll snicoll modified the milestones: 2.0.x, 2.x Oct 9, 2018
@snicoll snicoll mentioned this issue Sep 29, 2019
Closed
@snicoll
Copy link
Member Author

snicoll commented Sep 29, 2019

The analysis on #18396 is quite interesting and should help us fix this issue.

This was referenced Mar 28, 2020
Closed
Closed
@davinkevin

This comment has been minimized.

Sign in to view
@davinkevin davinkevin mentioned this issue Aug 17, 2020
Closed
@snicoll snicoll mentioned this issue Oct 28, 2020
Closed
@philwebb philwebb modified the milestones: 2.x, 2.2.x Oct 29, 2020
@philwebb philwebb assigned philwebb and unassigned snicoll Oct 29, 2020
@philwebb philwebb changed the title Incremental compilation does not keep metadata for NestedConfigurationProperty Incremental compilation does not keep metadata for inner classes Oct 29, 2020
@philwebb philwebb mentioned this issue Oct 29, 2020
Closed
@philwebb philwebb modified the milestones: 2.2.x, 2.2.11 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
2.2.11
Development

Successfully merging a pull request may close this issue.

Fix for issue #10886 "Incremental compilation does not keep metadata…"
3 participants
@snicoll @philwebb @davinkevin