From a5a955e5c754616d71b5cd31630960a56240d892 Mon Sep 17 00:00:00 2001 From: Yanming Zhou Date: Mon, 22 Nov 2021 11:08:38 +0800 Subject: [PATCH] LettuceMetricsAutoConfiguration should not build ClientResources instance Fix: i.l.c.r.DefaultClientResources WARN io.lettuce.core.resource.DefaultClientResources was not shut down properly, shutdown() was not called before it's garbage-collected. Call shutdown() or shutdown(long,long,TimeUnit) --- .../metrics/redis/LettuceMetricsAutoConfiguration.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java index c3eba92f5a95..d7490d76b50d 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java @@ -36,6 +36,7 @@ * Auto-configuration for Lettuce metrics. * * @author Antonin Arquey + * @author Yanming Zhou * @since 2.6.0 */ @Configuration(proxyBeanMethods = false) @@ -48,8 +49,7 @@ public class LettuceMetricsAutoConfiguration { @Bean public ClientResourcesBuilderCustomizer lettuceMetrics(MeterRegistry meterRegistry) { MicrometerOptions options = MicrometerOptions.builder().histogram(true).build(); - return (client) -> client.commandLatencyRecorder(new MicrometerCommandLatencyRecorder(meterRegistry, options)) - .build(); + return (client) -> client.commandLatencyRecorder(new MicrometerCommandLatencyRecorder(meterRegistry, options)); } }