From 5f0bf91b3e58910fb0ca7e76ced2852dc4f1dc47 Mon Sep 17 00:00:00 2001 From: Yanming Zhou Date: Mon, 22 Nov 2021 11:08:38 +0800 Subject: [PATCH] LettuceMetricsAutoConfiguration should not build ClientResources instance Fix: i.l.c.r.DefaultClientResources WARN io.lettuce.core.resource.DefaultClientResources was not shut down properly, shutdown() was not called before it's garbage-collected. Call shutdown() or shutdown(long,long,TimeUnit) --- .../metrics/redis/LettuceMetricsAutoConfiguration.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java index c3eba92f5a95..67f080ce20a8 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/redis/LettuceMetricsAutoConfiguration.java @@ -48,8 +48,7 @@ public class LettuceMetricsAutoConfiguration { @Bean public ClientResourcesBuilderCustomizer lettuceMetrics(MeterRegistry meterRegistry) { MicrometerOptions options = MicrometerOptions.builder().histogram(true).build(); - return (client) -> client.commandLatencyRecorder(new MicrometerCommandLatencyRecorder(meterRegistry, options)) - .build(); + return (client) -> client.commandLatencyRecorder(new MicrometerCommandLatencyRecorder(meterRegistry, options)); } }