Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for the configuration of multiple ContainerCustomizer at a time #1517

Closed
rfelgent opened this issue Oct 17, 2022 · 0 comments
Closed

add support for the configuration of multiple ContainerCustomizer at a time #1517

rfelgent opened this issue Oct 17, 2022 · 0 comments
Labels
type: enhancement
Milestone
3.0.0

Comments

@rfelgent
Copy link
Contributor

rfelgent commented Oct 17, 2022 •
edited

Expected Behavior

[Simple|Direct]MessageListenerContainer should support the configuration of multiple ContainerCustomizier<?> at a time.

Current Behavior

[Simple|Direct]MessageListenerContainer supports the configuration of exactly one ContainerCustomizier<?> at a time.

Context

I would like to split up my custom configuration requirements accross multiple ContainerCustomizier<?> in order to comply with
seperation of concerns and kiss principle (one customizer for concurrency settings, one customizer for error handling and so on)

This feature request was originally raised here #spring-projects/spring-boot/issues/32617. The prefered solution was discussed there, too: CompositeContainerCustomizer<?>

I will start making a pull request.

fyi @garyrussell
rfelgent added a commit to gvl-mbh/spring-amqp that referenced this issue Oct 17, 2022
@rfelgent
spring-projectsGH-1517: added configuration support for multiple Cont…
ccd7f3f 
…ainerCustomizer at once
@rfelgent rfelgent mentioned this issue Oct 17, 2022
Closed
rfelgent added a commit to gvl-mbh/spring-amqp that referenced this issue Oct 17, 2022
@rfelgent
spring-projectsGH-1517: added configuration support for multiple Cont…
b62a44d 
…ainerCustomizer at once
@garyrussell garyrussell added this to the 3.0.0 milestone Oct 17, 2022
garyrussell pushed a commit that referenced this issue Oct 18, 2022
@rfelgent @garyrussell
GH-1517: Add CompositeContainerCustomizer
b3bab6b 
Resolves #1517

Add configuration support for multiple ContainerCustomizer at once
garyrussell added a commit that referenced this issue Oct 18, 2022
@garyrussell
GH-1517: Docs and Polishing for Composite Cust.
b63cd5b
garyrussell added a commit that referenced this issue Oct 18, 2022
@garyrussell
GH-1517: Add Since Tag
76a4b87
garyrussell added a commit that referenced this issue Oct 18, 2022
@garyrussell
GH-1517: Docs and Polishing for Composite Cust.
b9b83f9
garyrussell added a commit that referenced this issue Oct 18, 2022
@garyrussell
GH-1517: Add Since Tag
0bc387f
garyrussell added a commit that referenced this issue Oct 18, 2022
@garyrussell
GH-1517: Fix Javadoc, CheckStyle
2a4a0ec
garyrussell added a commit that referenced this issue Oct 18, 2022
@garyrussell
GH-1517: Fix Javadoc, CheckStyle
399eff9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@garyrussell @rfelgent