Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ Super Streams with Single Active Consumer #1465

Closed
garyrussell opened this issue Jun 16, 2022 · 5 comments · Fixed by #1501
Closed

RabbitMQ Super Streams with Single Active Consumer #1465

garyrussell opened this issue Jun 16, 2022 · 5 comments · Fixed by #1501

Comments

@garyrussell
Copy link
Contributor

Add support for super streams.

@garyrussell garyrussell added this to the 3.0.0-M4 milestone Jun 16, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jun 21, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 7, 2022
Resolves spring-projects#1465

Add support for single active consumers on super streams.

Stop containers in test.

Use Snapshot Repo

Use snapshot repo; use TestContainers.
artembilan pushed a commit that referenced this issue Sep 7, 2022
Resolves #1465

Add support for single active consumers on super streams.

Stop containers in test.

Use Snapshot Repo

Use snapshot repo; use TestContainers.
@artembilan
Copy link
Member

I'm reopening this one since it fails on CI https://build.spring.io/chain/result/viewChainResult.action?planKey=AMQP-MAIN&buildNumber=1656 and locally for me as well.
Somehow this super stream is not consumed at all.
When I make this change to the test:

			container.setQueueNames("ss.sac.test-0");
//			container.superStream("ss.sac.test", "test");

I got some interactivity:

(Body:'foo' MessageProperties [headers={}, contentType=text/plain, contentEncoding=UTF-8, contentLength=0, deliveryMode=PERSISTENT, expiration=0, priority=0, deliveryTag=0])
(Body:'foo' MessageProperties [headers={}, contentType=text/plain, contentEncoding=UTF-8, contentLength=0, deliveryMode=PERSISTENT, expiration=0, priority=0, deliveryTag=0])
(Body:'foo' MessageProperties [headers={}, contentType=text/plain, contentEncoding=UTF-8, contentLength=0, deliveryMode=PERSISTENT, expiration=0, priority=0, deliveryTag=0])

Which means that setup is OK, but super stream feature doesn't work.
Perhaps something else has to be configured in the environment...

I'm disabling SuperStreamSACTests for time being.

Thank you!

@artembilan artembilan reopened this Sep 8, 2022
@acogoluegnes
Copy link
Contributor

@artembilan The test passes on my machine with

./gradlew :spring-rabbit-stream:test --tests "org.springframework.rabbit.stream.listener.SuperStreamSACTests"

I suspect you're having an old Docker image in your cache, try to delete it and run the test again:

docker rmi pivotalrabbitmq/rabbitmq-stream

It may be the same on CI.

@artembilan
Copy link
Member

Thank you, @acogoluegnes !

That really works.

I had to do it manually though:

docker rmi pivotalrabbitmq/rabbitmq-stream
docker logout
docker pull pivotalrabbitmq/rabbitmq-stream

Because Testcontainers somehow cannot pull the image for me - invalid credentials 😢 .

Will ask Trevor to remove that image from our CI Docker.

@eddumelendez
Copy link

@artembilan maybe time to upgrade from testcontainers 1.15.3 to 1.17.3. IIRC the issue you are having should be solved by now.

@artembilan
Copy link
Member

Thank you, @eddumelendez !

That really makes sense: I do use the latest Testcontainers in other projects.
Will update here shortly.

And will double check the anonymous image pull respectively 😉

garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 22, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 22, 2022
artembilan pushed a commit that referenced this issue Sep 22, 2022
To support spring-cloud-stream.

* Only include the ordinal in the queue name, not the whole routing key.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 26, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants