Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HOP Dependency (2.4.x) #1419

Closed
garyrussell opened this issue Feb 1, 2022 · 1 comment · Fixed by #1511
Closed

Remove HOP Dependency (2.4.x) #1419

garyrussell opened this issue Feb 1, 2022 · 1 comment · Fixed by #1511
Assignees
@garyrussell
Labels
backport:2.4.x (obsolete) type: task
Milestone
3.0.0-RC1

Comments

@garyrussell
Copy link
Contributor

Hop will no longer support JDK 8 before the end of life of 2.4.x; there is only one hard dependency on Hop (in LocalizedQueueConnectionFactory to determine the hosting node of a classic mirrored queue).
@garyrussell garyrussell added this to the Backlog milestone Feb 1, 2022
@garyrussell garyrussell self-assigned this Feb 1, 2022
@acogoluegnes
Copy link
Contributor

LocalizedQueueConnectionFactory uses only the /queues/{vhost}/{queue} endpoint. The easiest would be to use the RestTemplate and Jackson, to keep the same dependencies as Hop.

@garyrussell garyrussell modified the milestones: Backlog, 3.0.0-RC1 Oct 10, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 10, 2022
@garyrussell
spring-projectsGH-1419: Remove RabbitMQ http-client Usage
29dc74f 
Resolves spring-projects#1419

Use Spring WebFlux instead, while allowing the user to choose some other technology
in the `LocalizedQueueConnectionFactory`..
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 10, 2022
@garyrussell
spring-projectsGH-1419: Remove RabbitMQ http-client Usage
2bc0841 
Resolves spring-projects#1419

Use Spring WebFlux instead, while allowing the user to choose some other technology
in the `LocalizedQueueConnectionFactory`..
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 10, 2022
@garyrussell
spring-projectsGH-1419: Remove RabbitMQ http-client Usage
859f926 
Resolves spring-projects#1419

Use Spring WebFlux instead, while allowing the user to choose some other technology
in the `LocalizedQueueConnectionFactory`.
@garyrussell garyrussell mentioned this issue Oct 10, 2022
Merged
artembilan pushed a commit that referenced this issue Oct 11, 2022
@garyrussell
GH-1419: Remove RabbitMQ http-client Usage
c143c5b 
Resolves #1419

Use Spring WebFlux instead, while allowing the user to choose some other technology
in the `LocalizedQueueConnectionFactory`.

* Rename DefaultNodeLocator; add generics.
* Remove unnecessary dependencies.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 11, 2022
@garyrussell
spring-projectsGH-1419: Add RestTemplateNodeLocator
d8171b4 
- also remove hard dependency on `spring-webflux` from `spring-rabbit-junit`.
artembilan pushed a commit that referenced this issue Oct 11, 2022
@garyrussell
GH-1419: Add RestTemplateNodeLocator
b1ae21c 
- also remove hard dependency on `spring-webflux` from `spring-rabbit-junit`.

* Use reactor-netty-http.

* Fix Javadoc.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 11, 2022
@garyrussell
spring-projectsGH-1419: Remove RabbitMQ http-client Usage
bb5804e 
Resolves spring-projects#1419

Use Spring WebFlux instead, while allowing the user to choose some other technology
in the `LocalizedQueueConnectionFactory`.

* Rename DefaultNodeLocator; add generics.
* Remove unnecessary dependencies.

spring-projectsGH-1419: Add RestTemplateNodeLocator

- also remove hard dependency on `spring-webflux` from `spring-rabbit-junit`.

Fix Javadoc.

Use RestTemplate for aliveness test; JVM HttpClient not available in Java 8.

Restore spring-rabbit-junit jackson dependency.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 11, 2022
@garyrussell
spring-projectsGH-1419: Remove RabbitMQ http-client Usage
a927143 
Resolves spring-projects#1419

Use Spring WebFlux instead, while allowing the user to choose some other technology
in the `LocalizedQueueConnectionFactory`.

* Rename DefaultNodeLocator; add generics.
* Remove unnecessary dependencies.

spring-projectsGH-1419: Add RestTemplateNodeLocator

- also remove hard dependency on `spring-webflux` from `spring-rabbit-junit`.

Fix Javadoc.

Use RestTemplate for aliveness test; JVM HttpClient not available in Java 8.

Restore spring-rabbit-junit jackson dependency.
@garyrussell garyrussell mentioned this issue Oct 11, 2022
Merged
artembilan pushed a commit that referenced this issue Oct 11, 2022
@garyrussell @artembilan
GH-1419: Remove RabbitMQ http-client Usage
6e3e246 
Resolves #1419

Use Spring WebFlux instead, while allowing the user to choose some other technology
in the `LocalizedQueueConnectionFactory`.

* Rename DefaultNodeLocator; add generics.
* Remove unnecessary dependencies.

GH-1419: Add RestTemplateNodeLocator

- also remove hard dependency on `spring-webflux` from `spring-rabbit-junit`.

Fix Javadoc.

Use RestTemplate for aliveness test; JVM HttpClient not available in Java 8.

Restore spring-rabbit-junit jackson dependency.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 12, 2022
@garyrussell
spring-projectsGH-1419: Fix Early Exit in NodeLocator
2b609fd 
If a node was returned by the REST call and the node was not in the map
of nodes to addreses, the loop exited early.

The incorrect variable was being tested (never null).

Also add a more sophisticated integration test - using 2 brokers, ensure that
the correct broker is located for the queue.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 12, 2022
@garyrussell
spring-projectsGH-1419: Fix Early Exit in NodeLocator
d462d07 
If a node was returned by the REST call and the node was not in the map
of nodes to addreses, the loop exited early.

The incorrect variable was being tested (never null).

Also add a more sophisticated integration test - using 2 brokers, ensure that
the correct broker is located for the queue.
artembilan pushed a commit that referenced this issue Oct 12, 2022
@garyrussell @artembilan
GH-1419: Fix Early Exit in NodeLocator
8045f2c 
If a node was returned by the REST call and the node was not in the map
of nodes to addreses, the loop exited early.

The incorrect variable was being tested (never null).

Also add a more sophisticated integration test - using 2 brokers, ensure that
the correct broker is located for the queue.
garyrussell added a commit that referenced this issue Oct 13, 2022
@garyrussell
GH-1419: Fix Early Exit in NodeLocator
1713452 
If a node was returned by the REST call and the node was not in the map
of nodes to addreses, the loop exited early.

The incorrect variable was being tested (never null).
garyrussell added a commit that referenced this issue Oct 14, 2022
@garyrussell
GH-1419: Sonar Fixes
4927cc5
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 14, 2022
@garyrussell
spring-projectsGH-1419: Sonar Fixes
c2c534d
garyrussell added a commit that referenced this issue Oct 14, 2022
@garyrussell
GH-1419: Fix Local Node Name in Tests
82c69d5 
Local node not always `rabbit@localhost`; can be `rabbit@realHostName`.
garyrussell added a commit that referenced this issue Oct 14, 2022
@garyrussell
GH-1419: Fix Local Node Name in Tests
fc984e0 
Local node not always `rabbit@localhost`; can be `rabbit@realHostName`.
garyrussell added a commit that referenced this issue Oct 14, 2022
@garyrussell
GH-1419: Increase New Code Test Coverage
6e23963
garyrussell added a commit that referenced this issue Oct 14, 2022
@garyrussell
GH-1419: Increase New Code Test Coverage
93ad8dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport:2.4.x (obsolete) type: task
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-1419: Remove RabbitMQ http-client Usage garyrussell/spring-amqp
2 participants
@garyrussell @acogoluegnes