Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab support incorrectly copies callouts from other blocks #68

Closed
sbrannen opened this issue Nov 17, 2022 · 2 comments
Closed

Tab support incorrectly copies callouts from other blocks #68

sbrannen opened this issue Nov 17, 2022 · 2 comments
Assignees
Milestone

Comments

@sbrannen
Copy link
Contributor

Overview

As mentioned in spring-projects/spring-framework#29505 and spring-projects/spring-framework@ac7d428, tabs incorrectly include callouts from other blocks within a section of the generated documentation if some blocks use callouts and others do not.

Related Issues

@sbrannen
Copy link
Contributor Author

sbrannen commented Nov 17, 2022

As a side note, I have discovered two workarounds for this.

  1. Include callouts for every pair of primary/secondary blocks within the same section of the documentation (which is what I did in spring-projects/spring-framework@ac7d428).
  2. Enclose any pair of primary/secondary blocks that do not use callouts in a double-underscore block, like below.
--
[source,java,indent=0,subs="verbatim,quotes",role="primary"]
.Java
----
	@PutMapping("/accounts/{account}")
	public String save(@ModelAttribute("account") Account account) {
		// ...
	}
----

[source,kotlin,indent=0,subs="verbatim,quotes",role="secondary"]
.Kotlin
----
	@PutMapping("/accounts/{account}")
	fun save(@ModelAttribute("account") account: Account): String {
		// ...
	}
----
--

@wilkinsona wilkinsona added this to the 0.0.4 milestone Nov 18, 2022
@wilkinsona wilkinsona self-assigned this Nov 18, 2022
@sbrannen
Copy link
Contributor Author

That was a very quick turnaround. Thanks, @wilkinsona! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants