Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for configuration issues #573

Closed
fdw opened this issue Feb 2, 2021 · 3 comments
Closed

Add logging for configuration issues #573

fdw opened this issue Feb 2, 2021 · 3 comments

Comments

@fdw
Copy link

fdw commented Feb 2, 2021

Describe the bug
We're using Spring Cloud 2020.0.1 with Spring Boot 2.4.2 and the new configuration setup (i.e. spring.config.import=vault://).
When configuring Spring Cloud Vault wrongly (i.e. inaccessible URL or invalid credentials), there is no error message about this. It just fails silently to import the properties.
An error message would reduce the necessary debugging time by a lot.

@M3hdi
Copy link

M3hdi commented Feb 9, 2021

You can have the desired behavior by setting the "spring.cloud.vault.fail-fast" config property to "true".
I think it's better to have the fail fast flag switched on by default, which is not currently the case.

@mp911de
Copy link
Member

mp911de commented Mar 10, 2021

We're missing a bit of infrastructure to be able to inject logger into SecretLeaseContainer and property sources. I created spring-projects/spring-vault#636 to provide the pre-requisites.

@mp911de
Copy link
Member

mp911de commented Mar 10, 2021

Closing this one as duplicate of #565.

@mp911de mp911de closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants