Skip to content

connectionRequestTimeout for httpClient Fixes gh-799 #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

galaxy-sea
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #817 (46bc695) into 3.1.x (ba07f19) will decrease coverage by 0.30%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              3.1.x     #817      +/-   ##
============================================
- Coverage     80.07%   79.76%   -0.31%     
+ Complexity      562      561       -1     
============================================
  Files            67       67              
  Lines          2068     2081      +13     
  Branches        284      284              
============================================
+ Hits           1656     1660       +4     
- Misses          253      262       +9     
  Partials        159      159              
Impacted Files Coverage Δ
...gn/clientconfig/HttpClient5FeignConfiguration.java 68.08% <100.00%> (+2.96%) ⬆️
...d/openfeign/support/FeignHttpClientProperties.java 95.12% <100.00%> (+0.60%) ⬆️
...mework/cloud/openfeign/FeignClientFactoryBean.java 74.71% <0.00%> (-3.45%) ⬇️

@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request and removed waiting-for-triage labels Jan 17, 2023
@OlgaMaciaszek OlgaMaciaszek linked an issue Jan 17, 2023 that may be closed by this pull request
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @galaxy-sea. LGTM.

@OlgaMaciaszek OlgaMaciaszek merged commit 10b55a0 into spring-cloud:3.1.x Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't config connection request timeout for http client
3 participants