Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jackson and use BOM #48

Merged
merged 1 commit into from Jul 7, 2020
Merged

Conversation

gilles
Copy link

@gilles gilles commented Jul 7, 2020

Let's cut a branch after that. There's more to update but at least this closes to open PRs

@gilles
Copy link
Author

gilles commented Jul 7, 2020

@mattnworb

@mattnworb mattnworb merged commit 7724ec6 into spotify:master Jul 7, 2020
@mattnworb
Copy link
Member

1.2.0 should be on its way to Maven Central now

I had to disable tests while doing the release though (mvn -B release:clean release:prepare release:perform -DskipTests -Darguments="-DskipTests"), I kept getting an error that I assumed was unrelated to any change (and I didn't think now was the time to sort it out)

[INFO] [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ hamcrest-util ---
[INFO] [INFO] Surefire report directory: /Users/mattbrown/code/spotify-java-hamcrest/util/target/surefire-reports
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Exception in thread "main" java.lang.reflect.InvocationTargetException
[INFO]  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[INFO]  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[INFO]  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[INFO]  at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[INFO]  at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:513)
[INFO]  at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:525)
[INFO] Caused by: java.lang.RuntimeException: Class java/util/UUID could not be instrumented.
[INFO]  at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:140)
[INFO]  at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:101)
[INFO]  at org.jacoco.agent.rt.internal_8ff85ea.PreMain.createRuntime(PreMain.java:55)
[INFO]  at org.jacoco.agent.rt.internal_8ff85ea.PreMain.premain(PreMain.java:47)
[INFO]  ... 6 more
[INFO] Caused by: java.lang.NoSuchFieldException: $jacocoAccess
[INFO]  at java.base/java.lang.Class.getField(Class.java:1999)
[INFO]  at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:138)
[INFO]  ... 9 more
[INFO] *** java.lang.instrument ASSERTION FAILED ***: "result" with message agent load/premain call failed at ./src/java.instrument/share/native/libinstrument/JPLISAgent.c line: 422
[INFO] FATAL ERROR in native method: processing of -javaagent failed, processJavaStart failed
[INFO] /bin/sh: line 1: 74703 Abort trap: 6           /Library/Java/JavaVirtualMachines/amazon-corretto-11.jdk/Contents/Home/bin/java -javaagent:/Users/mattbrown/.m2/repository/org/jacoco/org.jacoco.agent/0.7.9/org.jacoco.agent-0.7.9-runtime.jar=destfile=/Users/mattbrown/code/spotify-java-hamcrest/util/target/jacoco.exec -jar /Users/mattbrown/code/spotify-java-hamcrest/util/target/surefire/surefirebooter914126945225596215.jar /Users/mattbrown/code/spotify-java-hamcrest/util/target/surefire/surefire5945765116208812657tmp /Users/mattbrown/code/spotify-java-hamcrest/util/target/surefire/surefire_014896908893623642881tmp
[INFO]
[INFO] Results :
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Reactor Summary for hamcrest 1.2.0:
[INFO] [INFO]
[INFO] [INFO] hamcrest ........................................... SUCCESS [  1.098 s]
[INFO] [INFO] hamcrest-util ...................................... FAILURE [  8.277 s]
[INFO] [INFO] hamcrest-jackson ................................... SKIPPED
[INFO] [INFO] hamcrest-optional .................................. SKIPPED
[INFO] [INFO] hamcrest-pojo ...................................... SKIPPED
[INFO] [INFO] hamcrest-future .................................... SKIPPED
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time:  9.643 s
[INFO] [INFO] Finished at: 2020-07-07T11:32:42-04:00
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project hamcrest-util: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? -> [Help 1]

@gilles
Copy link
Author

gilles commented Jul 7, 2020

if you're building with java11 we need to update jacoco. I'll spend some time updating the foss-root and some other library updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants