Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hamcrest #47

Merged
merged 2 commits into from Jul 7, 2020
Merged

Update hamcrest #47

merged 2 commits into from Jul 7, 2020

Conversation

gilles
Copy link

@gilles gilles commented Jul 6, 2020

Also use the main module, -core, -xxx are deprecated

Also use the main module, -core, -xxx are deprecated
@gilles
Copy link
Author

gilles commented Jul 6, 2020

@mattnworb

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna bump the version too? maybe 1.2.x?

@gilles
Copy link
Author

gilles commented Jul 6, 2020

make sense. done.

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@gilles
Copy link
Author

gilles commented Jul 7, 2020

I don't have merge/release privileges. Would you mind either adding me or merging. I can take care of the jackson update (2 related open PR) before we release

@mattnworb
Copy link
Member

@gilles sure just let me know when you want a release cut

@mattnworb mattnworb merged commit af9de30 into spotify:master Jul 7, 2020
@gilles gilles deleted the update_hamcrest branch July 7, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants