Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forking of plugin #127

Closed
klaraward opened this issue Feb 15, 2022 · 6 comments
Closed

Support forking of plugin #127

klaraward opened this issue Feb 15, 2022 · 6 comments
Assignees

Comments

@klaraward
Copy link
Contributor

klaraward commented Feb 15, 2022

Support forking of the plugin to be able to set jvm args needed to run with Java 16+.

After doing so, also remove the args in .mvn/jvm.config and in <argLine> introduced in #125

@Stephan202
Copy link
Contributor

@klaraward will this be an optional feature? I'm asking because our builds have suitable args in .mvn/jvm.config for other reasons anyway, so we'd rather not unnecessarily pay for the overhead of forking the JVM.

@klaraward
Copy link
Contributor Author

Yes, forking will definitely be optional.

@klaraward
Copy link
Contributor Author

I plan to work on this the coming days.

@klaraward klaraward self-assigned this Mar 7, 2022
@danielnorberg
Copy link
Contributor

Resolved by #140

@norrisjeremy
Copy link

Can this be adjusted to always add the --add-exports & --add-opens statements when forkMode is set to always?
This would allow users a way to remove the An illegal reflective access operation has occurred warnings that are seen when using Java < 16.

@danielnorberg
Copy link
Contributor

@norrisjeremy I reopened #106 to continue the discussion on whether and how to eliminate these warnings on Java < 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants