Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Upgrade docker-client dep from 8.14.1 to 8.16.0 #430

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Upgrade docker-client dep from 8.14.1 to 8.16.0 #430

merged 4 commits into from
Sep 12, 2019

Conversation

davidxia
Copy link
Contributor

No description provided.

@davidxia davidxia mentioned this pull request Sep 11, 2019
Closed
mattnworb
mattnworb approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the build failure is transient

@davidxia
Copy link
Contributor Author

Build failed bc

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project docker-maven-plugin: Failed during checkstyle configuration: cannot initialize module SuppressionFilter - Cannot set property 'file' to 'checkstyle-suppressions.xml' in module SuppressionFilter: InvocationTargetException: Unable to find: checkstyle-suppressions.xml: http://www.puppycrawl.com/dtds/suppressions_1_0.dtd -> [Help 1]

But I'm not sure why it can't find checkstyle-suppressions.xml which exists.

@lavanyachennupati
Copy link

Try specifying the <supressionsLocation> as here
https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/suppressions-filter.html
We specify the configLocation for the checkstyle.xml file too. Not sure what the default location is
https://github.com/spotify/docker-maven-plugin/blob/master/pom.xml#L289

@davidxia
Temporarily disable checkstyle
c93a56b 
Not able to figure out why I keep getting

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project docker-maven-plugin: Failed during checkstyle configuration: cannot initialize module SuppressionFilter - Cannot set property 'file' to 'checkstyle-suppressions.xml' in module SuppressionFilter: InvocationTargetException: Unable to find: checkstyle-suppressions.xml: http://www.puppycrawl.com/dtds/suppressions_1_0.dtd -> [Help 1]

`checkstyle-suppressions.xml` definitely exists.

In other words I can't figure out what's the relevant different
between this last successful build on travis-ci.org
https://travis-ci.org/spotify/docker-maven-plugin/jobs/442988171
and the failing builds on travis-ci.com
https://travis-ci.com/spotify/docker-maven-plugin/builds.

I'm also able to repro the checkstyle error locally.
@davidxia
Upgrade findbugs-maven-plugin from 3.0.0 to 3.0.5
bbe5ce2 
Build now fails with this error. https://issues.apache.org/jira/browse/MNG-6625
@davidxia davidxia force-pushed the dxia/upgrade-docker-client branch 2 times, most recently from 04810ae to 02cf2bc Compare September 12, 2019 01:06
@davidxia davidxia merged commit 6db655f into master Sep 12, 2019
@davidxia davidxia deleted the dxia/upgrade-docker-client branch September 12, 2019 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattnworb mattnworb mattnworb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidxia @lavanyachennupati @mattnworb