Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rank matcher and its documentation do not match #566

Closed
matthiasjordan opened this issue Feb 23, 2018 · 1 comment
Closed

Rank matcher and its documentation do not match #566

matthiasjordan opened this issue Feb 23, 2018 · 1 comment
Labels
documentation good first issue

Comments

@matthiasjordan
Copy link

According to the documentation, the Rank matcher "matches warnings with a particular bug rank". According to its implementation, it matches if the bug's rank is >= the matcher's rank. This is in contradiction of the documentation. Also, I don't see the use case for "let's break the build if any bug is found that is less important than rank X".

There is a workaround using and but it makes the filter code ridiculous (matching exactly rank 4 would need to match "4 and not 5").
jeff303 pushed a commit to jeff303/spotbugs that referenced this issue Oct 30, 2020
Rank matcher and its documentation do not match - spotbugs#566
7aa675c 
Updating docs to use "at least" terminology for rank matcher
KengoTODA pushed a commit that referenced this issue Nov 23, 2020
@KengoTODA
Rank matcher and its documentation do not match - #566
cdfd0af 
Updating docs to use "at least" terminology for rank matcher
@KengoTODA
Copy link
Member

closed by #1359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KengoTODA @matthiasjordan