Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Freezes during "bug count" decoration #285

Closed
cdietrich opened this issue Jul 25, 2017 · 3 comments · Fixed by #1945
Closed

UI Freezes during "bug count" decoration #285

cdietrich opened this issue Jul 25, 2017 · 3 comments · Fixed by #1945
Assignees

Comments

@cdietrich
Copy link

Eclipse Reports UI Freezes on the label decorators of the findbugs plugin
here are a number of sample traces

Stack Trace
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:82)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator.java:129)
	at org.eclipse.core.internal.resources.MarkerManager.visitorFindMarkers(MarkerManager.java:620)
	at org.eclipse.core.internal.resources.MarkerManager.doFindMarkers(MarkerManager.java:283)
	at org.eclipse.core.internal.resources.MarkerManager.findMarkers(MarkerManager.java:268)
	at org.eclipse.core.internal.resources.Resource.findMarkers(Resource.java:987)
	at de.tobject.findbugs.reporter.MarkerUtil.getMarkers(MarkerUtil.java:1002)
	at de.tobject.findbugs.builder.WorkItem.getMarkers(WorkItem.java:297)
	at de.tobject.findbugs.builder.WorkItem.getMarkerCount(WorkItem.java:284)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:68)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:50)
	at org.eclipse.ui.internal.decorators.FullDecoratorDefinition.decorateText(FullDecoratorDefinition.java:133)
	at org.eclipse.ui.internal.decorators.FullTextDecoratorRunnable.run(FullTextDecoratorRunnable.java:24)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.decorators.DecoratorManager.safeDecorateText(DecoratorManager.java:497)
	at org.eclipse.ui.internal.decorators.DecoratorManager.decorateText(DecoratorManager.java:453)
	at org.eclipse.ui.internal.decorators.DecoratorManager$ManagedWorkbenchLabelDecorator.decorateText(DecoratorManager.java:151)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.getStyledText(DecoratingStyledCellLabelProvider.java:202)
	at org.eclipse.jface.viewers.DelegatingStyledCellLabelProvider.update(DelegatingStyledCellLabelProvider.java:106)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.update(DecoratingStyledCellLabelProvider.java:131)
	at org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerColumn.java:141)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:946)
	at org.eclipse.jface.viewers.AbstractTreeViewer$UpdateItemSafeRunnable.run(AbstractTreeViewer.java:117)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$8/1788152379.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:1025)
	at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run(StructuredViewer.java:475)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$8/1788152379.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.jface.viewers.StructuredViewer.updateItem(StructuredViewer.java:2159)
	at org.eclipse.jface.viewers.StructuredViewer.internalUpdate(StructuredViewer.java:2142)
	at org.eclipse.jface.viewers.StructuredViewer.update(StructuredViewer.java:2083)
	at org.eclipse.jface.viewers.ColumnViewer.update(ColumnViewer.java:542)
	at org.eclipse.jface.viewers.StructuredViewer.update(StructuredViewer.java:2027)
	at org.eclipse.jface.viewers.StructuredViewer.handleLabelProviderChanged(StructuredViewer.java:1203)
	at org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer.handleLabelProviderChanged(ProblemTreeViewer.java:206)
	at org.eclipse.jface.viewers.ContentViewer$1.labelProviderChanged(ContentViewer.java:99)
	at org.eclipse.jface.viewers.BaseLabelProvider$1.run(BaseLabelProvider.java:72)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$8/1788152379.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.jface.viewers.BaseLabelProvider.fireLabelProviderChanged(BaseLabelProvider.java:69)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.lambda$0(DecoratingStyledCellLabelProvider.java:75)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider$$Lambda$256/1018364889.labelProviderChanged(Unknown Source)
	at org.eclipse.ui.internal.decorators.DecoratorManager$1.run(DecoratorManager.java:374)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.decorators.DecoratorManager.fireListener(DecoratorManager.java:371)
	at org.eclipse.ui.internal.decorators.DecorationScheduler$3.runInUIThread(DecorationScheduler.java:485)
	at org.eclipse.ui.progress.UIJob.lambda$0(UIJob.java:95)
	at org.eclipse.ui.progress.UIJob$$Lambda$336/2097461361.run(Unknown Source)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:37)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4497)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4110)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1155)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1044)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
	at org.eclipse.ui.internal.Workbench$$Lambda$70/2055291664.run(Unknown Source)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1499)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1472)

Stack Trace
	at org.eclipse.core.runtime.Path.initialize(Path.java:669)
	at org.eclipse.core.runtime.Path.<init>(Path.java:208)
	at org.eclipse.core.internal.watson.ElementTreeIterator.requestPath(ElementTreeIterator.java:167)
	at org.eclipse.core.internal.resources.MarkerManager$3.visitElement(MarkerManager.java:615)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:82)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:87)
	at org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator.java:129)
	at org.eclipse.core.internal.resources.MarkerManager.visitorFindMarkers(MarkerManager.java:620)
	at org.eclipse.core.internal.resources.MarkerManager.doFindMarkers(MarkerManager.java:283)
	at org.eclipse.core.internal.resources.MarkerManager.findMarkers(MarkerManager.java:268)
	at org.eclipse.core.internal.resources.Resource.findMarkers(Resource.java:987)
	at de.tobject.findbugs.reporter.MarkerUtil.getMarkers(MarkerUtil.java:1002)
	at de.tobject.findbugs.builder.WorkItem.getMarkers(WorkItem.java:297)
	at de.tobject.findbugs.builder.WorkItem.getMarkerCount(WorkItem.java:284)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:68)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:50)
	at org.eclipse.ui.internal.decorators.FullDecoratorDefinition.decorateText(FullDecoratorDefinition.java:133)
	at org.eclipse.ui.internal.decorators.FullTextDecoratorRunnable.run(FullTextDecoratorRunnable.java:24)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.decorators.DecoratorManager.safeDecorateText(DecoratorManager.java:497)
	at org.eclipse.ui.internal.decorators.DecoratorManager.decorateText(DecoratorManager.java:453)
	at org.eclipse.ui.internal.decorators.DecoratorManager$ManagedWorkbenchLabelDecorator.decorateText(DecoratorManager.java:151)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.getStyledText(DecoratingStyledCellLabelProvider.java:202)
	at org.eclipse.jface.viewers.DelegatingStyledCellLabelProvider.update(DelegatingStyledCellLabelProvider.java:106)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.update(DecoratingStyledCellLabelProvider.java:131)
	at org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerColumn.java:141)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:946)
	at org.eclipse.jface.viewers.AbstractTreeViewer$UpdateItemSafeRunnable.run(AbstractTreeViewer.java:117)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$8/1788152379.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:1025)
	at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run(StructuredViewer.java:475)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$8/1788152379.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.jface.viewers.StructuredViewer.updateItem(StructuredViewer.java:2159)
	at org.eclipse.jface.viewers.StructuredViewer.internalUpdate(StructuredViewer.java:2142)
	at org.eclipse.jface.viewers.StructuredViewer.update(StructuredViewer.java:2083)
	at org.eclipse.jface.viewers.ColumnViewer.update(ColumnViewer.java:542)
	at org.eclipse.jface.viewers.StructuredViewer.update(StructuredViewer.java:2027)
	at org.eclipse.jface.viewers.StructuredViewer.handleLabelProviderChanged(StructuredViewer.java:1203)
	at org.eclipse.jdt.internal.ui.viewsupport.ProblemTreeViewer.handleLabelProviderChanged(ProblemTreeViewer.java:206)
	at org.eclipse.jface.viewers.ContentViewer$1.labelProviderChanged(ContentViewer.java:99)
	at org.eclipse.jface.viewers.BaseLabelProvider$1.run(BaseLabelProvider.java:72)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$8/1788152379.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.jface.viewers.BaseLabelProvider.fireLabelProviderChanged(BaseLabelProvider.java:69)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.lambda$0(DecoratingStyledCellLabelProvider.java:75)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider$$Lambda$256/1018364889.labelProviderChanged(Unknown Source)
	at org.eclipse.ui.internal.decorators.DecoratorManager$1.run(DecoratorManager.java:374)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.decorators.DecoratorManager.fireListener(DecoratorManager.java:371)
	at org.eclipse.ui.internal.decorators.DecorationScheduler$3.runInUIThread(DecorationScheduler.java:485)
	at org.eclipse.ui.progress.UIJob.lambda$0(UIJob.java:95)
	at org.eclipse.ui.progress.UIJob$$Lambda$336/2097461361.run(Unknown Source)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:37)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4497)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4110)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
	at org.eclipse.jface.window.Window.open(Window.java:794)
	at org.eclipse.ui.internal.views.log.EventDetailsDialog.open(EventDetailsDialog.java:191)
	at org.eclipse.ui.internal.views.log.EventDetailsDialogAction.run(EventDetailsDialogAction.java:99)
	at org.eclipse.ui.internal.views.log.LogView.lambda$2(LogView.java:561)
	at org.eclipse.ui.internal.views.log.LogView$$Lambda$487/435254131.doubleClick(Unknown Source)
	at org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:831)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil.lambda$0(JFaceUtil.java:44)
	at org.eclipse.ui.internal.JFaceUtil$$Lambda$8/1788152379.run(Unknown Source)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:828)
	at org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1459)
	at org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1258)
	at org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:249)
	at org.eclipse.jface.util.OpenStrategy.access$0(OpenStrategy.java:247)
	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:306)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5252)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4522)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4107)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1155)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1044)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
	at org.eclipse.ui.internal.Workbench$$Lambda$70/2055291664.run(Unknown Source)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1499)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1472)

disabling the count decorators for findbugs seems to help

@JanecekPetr
Copy link

FYI, still happening with the newest eclipse and Spotbugs, all the stack traces are very similar to each other and basicalyl identical to the one reported above.

UI freeze of 150s:

eclipse.buildId=4.19.0.I20210303-1800
java.version=15.0.2
java.vendor=AdoptOpenJDK
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US

Stack Trace
	at java.base@15.0.2/java.lang.StringLatin1.indexOf(StringLatin1.java:214)
	at java.base@15.0.2/java.lang.String.indexOf(String.java:1617)
	at java.base@15.0.2/java.lang.String.indexOf(String.java:1574)
	at org.eclipse.core.runtime.Path.<init>(Path.java:209)
	at org.eclipse.core.internal.watson.ElementTreeIterator.requestPath(ElementTreeIterator.java:173)
	at org.eclipse.core.internal.resources.MarkerManager.lambda$1(MarkerManager.java:607)
	at org.eclipse.core.internal.resources.MarkerManager$$Lambda$465/0x0000000800ebe1a0.visitElement(Unknown Source)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:85)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator.java:135)
	at org.eclipse.core.internal.resources.MarkerManager.visitorFindMarkers(MarkerManager.java:611)
	at org.eclipse.core.internal.resources.MarkerManager.doFindMarkers(MarkerManager.java:290)
	at org.eclipse.core.internal.resources.MarkerManager.findMarkers(MarkerManager.java:274)
	at org.eclipse.core.internal.resources.Resource.findMarkers(Resource.java:988)
	at de.tobject.findbugs.reporter.MarkerUtil.getMarkers(MarkerUtil.java:998)
	at de.tobject.findbugs.builder.WorkItem.getMarkers(WorkItem.java:307)
	at de.tobject.findbugs.builder.WorkItem.getMarkerCount(WorkItem.java:282)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:56)
	at org.eclipse.ui.internal.decorators.FullDecoratorDefinition.decorateText(FullDecoratorDefinition.java:128)
	at org.eclipse.ui.internal.decorators.FullTextDecoratorRunnable.run(FullTextDecoratorRunnable.java:26)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
	at org.eclipse.ui.internal.decorators.DecoratorManager.safeDecorateText(DecoratorManager.java:456)
	at org.eclipse.ui.internal.decorators.DecoratorManager.decorateText(DecoratorManager.java:420)
	at org.eclipse.ui.internal.decorators.DecoratorManager$ManagedWorkbenchLabelDecorator.decorateText(DecoratorManager.java:150)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.getStyledText(DecoratingStyledCellLabelProvider.java:205)
	at org.eclipse.jface.viewers.DelegatingStyledCellLabelProvider.update(DelegatingStyledCellLabelProvider.java:109)
	at org.eclipse.jface.viewers.DecoratingStyledCellLabelProvider.update(DecoratingStyledCellLabelProvider.java:134)
	at org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerColumn.java:144)
	at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:959)
	at org.eclipse.jface.viewers.AbstractTreeViewer$UpdateItemSafeRunnable.run(AbstractTreeViewer.java:126)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
    ...

@iloveeclipse iloveeclipse changed the title UI Freezes Reported in Findbugs Eclipse UI Freezes during "bug count" decoration Feb 6, 2022
@iloveeclipse iloveeclipse self-assigned this Feb 6, 2022
@iloveeclipse
Copy link
Member

In light of https://bugs.eclipse.org/bugs/show_bug.cgi?id=450663#c69 I will see if the same approach can be applied for spotbugs decorator.

@iloveeclipse
Copy link
Member

iloveeclipse commented Feb 6, 2022

Stacks on latest 4.23 build are

Stack Trace
	at java.base@11.0.8/java.lang.StringLatin1.indexOf(StringLatin1.java:213)
	at java.base@11.0.8/java.lang.String.indexOf(String.java:1578)
	at java.base@11.0.8/java.lang.String.indexOf(String.java:1535)
	at org.eclipse.core.runtime.Path.<init>(Path.java:209)
	at org.eclipse.core.internal.watson.ElementTreeIterator.requestPath(ElementTreeIterator.java:173)
	at org.eclipse.core.internal.resources.MarkerManager.lambda$1(MarkerManager.java:607)
	at org.eclipse.core.internal.resources.MarkerManager$$Lambda$1001/0x0000000800c7cc40.visitElement(Unknown Source)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:85)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator.java:135)
	at org.eclipse.core.internal.resources.MarkerManager.visitorFindMarkers(MarkerManager.java:611)
	at org.eclipse.core.internal.resources.MarkerManager.doFindMarkers(MarkerManager.java:290)
	at org.eclipse.core.internal.resources.MarkerManager.findMarkers(MarkerManager.java:274)
	at org.eclipse.core.internal.resources.Resource.findMarkers(Resource.java:988)
	at de.tobject.findbugs.reporter.MarkerUtil.getMarkers(MarkerUtil.java:998)
	at de.tobject.findbugs.builder.WorkItem.getMarkers(WorkItem.java:295)
	at de.tobject.findbugs.builder.WorkItem.getMarkerCount(WorkItem.java:282)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:70)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:52)
	at org.eclipse.ui.internal.decorators.FullDecoratorDefinition.decorateText(FullDecoratorDefinition.java:128)
Stack Trace
	at org.eclipse.core.internal.resources.MarkerSet.elements(MarkerSet.java:93)
	at org.eclipse.core.internal.resources.MarkerManager.basicFindMatching(MarkerManager.java:105)
	at org.eclipse.core.internal.resources.MarkerManager.lambda$1(MarkerManager.java:606)
	at org.eclipse.core.internal.resources.MarkerManager$$Lambda$1001/0x0000000800c7cc40.visitElement(Unknown Source)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:85)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:90)
	at org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator.java:135)
	at org.eclipse.core.internal.resources.MarkerManager.visitorFindMarkers(MarkerManager.java:611)
	at org.eclipse.core.internal.resources.MarkerManager.doFindMarkers(MarkerManager.java:290)
	at org.eclipse.core.internal.resources.MarkerManager.findMarkers(MarkerManager.java:274)
	at org.eclipse.core.internal.resources.Resource.findMarkers(Resource.java:988)
	at de.tobject.findbugs.reporter.MarkerUtil.getMarkers(MarkerUtil.java:998)
	at de.tobject.findbugs.builder.WorkItem.getMarkers(WorkItem.java:295)
	at de.tobject.findbugs.builder.WorkItem.getMarkerCount(WorkItem.java:282)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:70)
	at de.tobject.findbugs.decorators.ResourceBugCountDecorator.decorateText(ResourceBugCountDecorator.java:52)
	at org.eclipse.ui.internal.decorators.FullDecoratorDefinition.decorateText(FullDecoratorDefinition.java:128)

iloveeclipse added a commit that referenced this issue Feb 6, 2022
See for detailed discussion and used solution approach
https://bugs.eclipse.org/bugs/show_bug.cgi?id=450663#c69

In short: one should not run any resource related operations on UI
thread while decorating bug counts, because resource operations can take
longer and UI will be frozen.

The patch ports basically JDT fix for ProblemsLabelDecorator (see
https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/190484) into the
Spotbugs ResourceBugCountDecorator. The "only" difference is that we
don't care about markers severities but want markers count, the rest is
almost identical.

Fixes issue #285
iloveeclipse added a commit that referenced this issue Feb 6, 2022
See for detailed discussion and used solution approach
https://bugs.eclipse.org/bugs/show_bug.cgi?id=450663#c69

In short: one should not run any resource related operations on UI
thread while decorating bug counts, because resource operations can take
longer and UI will be frozen.

The patch ports basically JDT fix for ProblemsLabelDecorator (see
https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/190484) into the
Spotbugs ResourceBugCountDecorator. The "only" difference is that we
don't care about markers severities but want markers count, the rest is
almost identical.

Fixes issue #285
iloveeclipse added a commit that referenced this issue Feb 6, 2022
See for detailed discussion and used solution approach
https://bugs.eclipse.org/bugs/show_bug.cgi?id=450663#c69

In short: one should not run any resource related operations on UI
thread while decorating bug counts, because resource operations can take
longer and UI will be frozen.

The patch ports basically JDT fix for ProblemsLabelDecorator (see
https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/190484) into the
Spotbugs ResourceBugCountDecorator. The "only" difference is that we
don't care about markers severities but want markers count, the rest is
almost identical.

Fixes issue #285
iloveeclipse added a commit that referenced this issue Feb 6, 2022
See for detailed discussion and used solution approach
https://bugs.eclipse.org/bugs/show_bug.cgi?id=450663#c69

In short: one should not run any resource related operations on UI
thread while decorating bug counts, because resource operations can take
longer and UI will be frozen.

The patch ports basically JDT fix for ProblemsLabelDecorator (see
https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/190484) into the
Spotbugs ResourceBugCountDecorator. The "only" difference is that we
don't care about markers severities but want markers count, the rest is
almost identical.

Fixes issue #285
@iloveeclipse iloveeclipse linked a pull request Feb 6, 2022 that will close this issue
1 task
iloveeclipse added a commit that referenced this issue Feb 7, 2022
See for detailed discussion and used solution approach
https://bugs.eclipse.org/bugs/show_bug.cgi?id=450663#c69

In short: one should not run any resource related operations on UI
thread while decorating bug counts, because resource operations can take
longer and UI will be frozen.

The patch ports basically JDT fix for ProblemsLabelDecorator (see
https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/190484) into the
Spotbugs ResourceBugCountDecorator. The "only" difference is that we
don't care about markers severities but want markers count, the rest is
almost identical.

Fixes issue #285
iloveeclipse added a commit that referenced this issue Feb 9, 2022
See for detailed discussion and used solution approach
https://bugs.eclipse.org/bugs/show_bug.cgi?id=450663#c69

In short: one should not run any resource related operations on UI
thread while decorating bug counts, because resource operations can take
longer and UI will be frozen.

The patch ports basically JDT fix for ProblemsLabelDecorator (see
https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/190484) into the
Spotbugs ResourceBugCountDecorator. The "only" difference is that we
don't care about markers severities but want markers count, the rest is
almost identical.

Fixes issue #285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants