Fix OpcodeStack to handle propagation of taints properly in case of string concatenation in Java 11 and above #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2022 15:47
…tring concatenation in Java 9 and above Instead of using StringBuffer or StringBuilder internally, Java 11 and above uses a dynamic call to makeConcatWithConstants() to append strings. Previously, `OpcodeStackDetector` did not handle the taint propagation properly in case of this dyanamic call which led to false negative such as the one described in issue [spotbugs#2184](spotbugs#2184). This PR fixes such issues by adding code to `OpcodeStackDetector` to handle this case as well.
|
No false positives and no crashes on some open-source projects we used to test our PRs. |
|
A side remark: I put the tests into the |
ThrawnCA
previously approved these changes
Sep 27, 2022
| servletRequestParameterTainted = true; | ||
| } | ||
| Object sVal = i.getConstant(); | ||
| if (sVal != null) { |
There was a problem hiding this comment.
"if not...else" is a double negative, could refactor.
ThrawnCA
previously approved these changes
Oct 4, 2022
ThrawnCA
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using StringBuffer or StringBuilder internally, Java 11 and above uses a dynamic call to makeConcatWithConstants() to append strings. Previously,
OpcodeStackDetectordid not handle the taint propagation properly in case of this dyanamic call which led to false negative such as the one described in issue #2184. This PR fixes such issues by adding code toOpcodeStackDetectorto handle this case as well.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code