Report bug SA_FIELD_SELF_ASSIGNMENT in nested classes as well
#2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug `SA_FIELD_SELF_ASSIGNMENT` was not reported in nested classes, only in the outer class. This lead to inconsistent behavior. See issue ([spotbugs#2142](spotbugs#2142)). This PR fixes this issue.
KengoTODA
requested changes
Sep 1, 2022
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindFieldSelfAssignment.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindFieldSelfAssignment.java
Outdated
Show resolved
Hide resolved
| public void afterOpcode(int seen) { | ||
| super.afterOpcode(seen); | ||
|
|
||
| if (seen == Const.GETFIELD && parentInstanceLoadFromRegister > -1) { |
There was a problem hiding this comment.
Could you replace this magic number -1 with a static final int field?
Better to tell our intention to who is reading our code.
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindFieldSelfAssignment.java
Show resolved
Hide resolved
…fAssignment.java Co-authored-by: Kengo TODA <skypencil+github@gmail.com>
…fAssignment.java Co-authored-by: Kengo TODA <skypencil+github@gmail.com>
|
Thank you for your comments, @KengoTODA! I think I fixed every one of them now. |
ThrawnCA
previously approved these changes
Sep 4, 2022
KengoTODA
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
SA_FIELD_SELF_ASSIGNMENTwas not reported in nested classes, only in the outer class. This lead to inconsistent behavior. See issue (#2142). This PR fixes this issue.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code