False positive EI_EXPOSE_REP when using List.copyOf

[josephearl]

Given the following class:

public class Test {
  private List<Integer> ints;

  public Test2(List<Integer> ints) {
    this.ints = List.copyOf(ints);
  }

  public List<Integer> getInts() {
    return ints;
  }
}

SpotBugs raises a warning EI_EXPOSE_REP because Test.getInts() may expose internal representation by returning Test.ints

However since List.copyOf creates an unmodifiable list, no mutable internal representation is returned and this is a false positive.

[welcome]

Thanks for opening your first issue here! 😃
Please check our contributing guideline. Especially when you report a problem, make sure you share a Minimal, Complete, and Verifiable example to reproduce it in this issue.

[osiegmar]

Similar to #1771

[baloghadamsoftware]

#2141 should fix this as well. Please confirm that the issue is resolved in Sputbugs version 4.7.2.

[josephearl]

Can confirm, updated yesterday and was able to remove the suppressions we had