Fix report output to truncate existing files #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdati
commented
Feb 8, 2022
| @@ -278,7 +278,8 @@ public boolean justPrintVersion() { | |||
| if (index >= 0) { | |||
| Path path = Paths.get(optionExtraPart.substring(index + 1)); | |||
| try { | |||
| OutputStream oStream = Files.newOutputStream(path, StandardOpenOption.CREATE, StandardOpenOption.WRITE); | |||
| OutputStream oStream = Files.newOutputStream(path, StandardOpenOption.CREATE, StandardOpenOption.WRITE, | |||
| StandardOpenOption.TRUNCATE_EXISTING); | |||
There was a problem hiding this comment.
Alternatively, this could have been changed to use the implicit/default behavior of newOutputStream() by not specifying any OpenOptions:
OutputStream oStream = Files.newOutputStream(path);
ThrawnCA
previously approved these changes
Feb 8, 2022
KengoTODA
requested changes
Mar 8, 2022
# Conflicts: # CHANGELOG.md
Done. Thank you for your work on SpotBugs! It is very useful. |
ThrawnCA
previously approved these changes
Mar 9, 2022
KengoTODA
reviewed
Mar 9, 2022
KengoTODA
previously approved these changes
Mar 10, 2022
KengoTODA
approved these changes
May 4, 2022
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1950 so report files are truncated when overwritten
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code