Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests from spotbugs to spotbugs-tests project #1914

Closed
iloveeclipse opened this issue Jan 9, 2022 · 0 comments · Fixed by #1912
Closed

Move tests from spotbugs to spotbugs-tests project #1914

iloveeclipse opened this issue Jan 9, 2022 · 0 comments · Fixed by #1912
Assignees
@iloveeclipse

Comments

@iloveeclipse
Copy link
Member

iloveeclipse commented Jan 9, 2022 •
edited

For whatever reason, some spotbugs tests were added inside spotbugs project, and some in the dedicated spotbugs-tests project.
With tests inside the main project we see issues like #1906, where tests use JDK API that shouldn't be used by spotbugs code itself, so compilation of spotbugs with Java 8 only can't be easily done.

It is better to separate production from test code - it avoids that production code may by accident contain references to test code or other unrelated test libraries, and also allows cleanly separated compilation settings.

So we should move junit tests from spotbugs to spotbugs-tests project.
I'm not sure I can do the same for "guiTests" because of more complex gradle scripts, but that could be done in a second step.
I have patch that covers both "usual" and "gui" unit tests.
@iloveeclipse iloveeclipse self-assigned this Jan 9, 2022
@iloveeclipse iloveeclipse mentioned this issue Jan 9, 2022
Closed
iloveeclipse added a commit that referenced this issue Jan 9, 2022
@iloveeclipse
Moved tests from spotbugs project to spotbugs-tests project
4071903 
The only change except moving sources is to configure two unstable tests
run before all other tests - this avoids the failure that can't be
observed if running tests one by one.

Fixes #1914
@iloveeclipse iloveeclipse mentioned this issue Jan 9, 2022
Merged
1 task
iloveeclipse added a commit that referenced this issue Jan 9, 2022
@iloveeclipse
Moved gui tests from spotbugs project to spotbugs-tests project
b2c71e0 
Second part needed to fully fix #1914
@iloveeclipse iloveeclipse linked a pull request Jan 9, 2022 that will close this issue
build: moved tests from spotbugs to spotbugs-tests project #1912
Merged
1 task
iloveeclipse added a commit that referenced this issue Jan 9, 2022
@iloveeclipse
Moved gui tests from spotbugs project to spotbugs-tests project
cd4ebec 
Second part needed to fully fix #1914
THis project does not have tests anymore, so jacoco is not needed.
iloveeclipse added a commit that referenced this issue Jan 12, 2022
@iloveeclipse
Moved tests from spotbugs project to spotbugs-tests project
eeb5c78 
The only change except moving sources is to configure two unstable tests
run before all other tests - this avoids the failure that can't be
observed if running tests one by one.

Fixes #1914
iloveeclipse added a commit that referenced this issue Jan 12, 2022
@iloveeclipse
Moved gui tests from spotbugs project to spotbugs-tests project
6825082 
Second part needed to fully fix #1914
THis project does not have tests anymore, so jacoco is not needed.
@iloveeclipse iloveeclipse mentioned this issue Jan 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: moved tests from spotbugs to spotbugs-tests project spotbugs/spotbugs
1 participant
@iloveeclipse