New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RV_DONT_JUST_NULL_CHECK_READLINE can detect MemoryCacheImageOutputStream #1818

Closed

Zustin opened this issue Nov 17, 2021 · 1 comment

Contributor

Zustin commented Nov 17, 2021 •

edited

Hi 😃 I find a false negative about the rule RV_DONT_JUST_NULL_CHECK_READLINE. Please refer to the below code sample.

SpotBugs should have reported a violation at line 3, but it does not. Hence, I think this is a false negative. Thanks for your consideration.

public void foo(OutputStream stream) throws IOException {
    MemoryCacheImageOutputStream os = new MemoryCacheImageOutputStream(stream);
    while(os.readLine() != null) {}
}

MySpotBugs version is 4.4.2 and I run it by Idea plugin and CLI.

Zustin mentioned this issue

Fix some false negative issues about the rule RV_DONT_JUST_NULL_CHECK_READLINE #1823

Merged

Contributor

gtoison commented Sep 6, 2023

This was fixed in #1823

gtoison closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment