-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DominatorsAnalysis to reflect exception handling strategy #1741
Conversation
Dominators analysis available thru ClassContext performs an analysis that disregards exception edges. References to DominatorsAnalysis were renamed to reflect this. Make ClassContext API for DominatorsAnalysis more descriptive Dominators and PostDominators analyses are made available via ClassContext API in exception-ignoring and implicit exception-ignoring variants.
Hey! |
.../src/main/java/edu/umd/cs/findbugs/classfile/engine/bcel/NonExceptionDominatorsAnalysis.java
Outdated
Show resolved
Hide resolved
...n/java/edu/umd/cs/findbugs/classfile/engine/bcel/NonImplicitExceptionDominatorsAnalysis.java
Outdated
Show resolved
Hide resolved
Thanks for the quick response! Fixed the license. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry in the CHANGELOG.md
to tell renamed classes, it could be necessary for plugin developers.
Good point, I have summarized the naming changes in |
CHANGELOG.md
Outdated
@@ -8,6 +8,10 @@ Currently the versioning policy of this project follows [Semantic Versioning v2. | |||
### Changed | |||
- Replace "分析" with "解析" in Japanese document ([#1573](https://github.com/spotbugs/spotbugs/issues/1573)) | |||
- Add a section to document how to integrate find-sec-bugs into spotbugs-maven-plugin ([#540](https://github.com/spotbugs/spotbugs/issues/540)) | |||
- Changes related to dominators analysis in package `edu.umd.cs.findbugs.classfile.engine.bcel`: | |||
- `DominiatorsAnalysisFactory` renamed to `NonExceptionDominatorsAnalysisFactory` (clarification) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misspelled "Dominators" (and yes, the original was correctly spelled)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, spelling is hard (for me at least) :)
Ironically, while trying to fix one spelling error, I introduced another one.
(not to mention that the lesson learned here contradicts my current efforts on using less copy-paste in general xD)
Dominators analysis available thru ClassContext performs an analysis that
disregards exception edges. References to DominatorsAnalysis were renamed to
reflect this.
Make ClassContext API for DominatorsAnalysis more descriptive
Dominators and PostDominators analyses are made available via
ClassContext API in exception-ignoring and implicit exception-ignoring
variants.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.md
if you have changed SpotBugs code