Remove dependencies on deprecated Gradle feature #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compileOnly configuration is not expected to refer from other projects, so load properties file in eclipsePlugni-junit and eclipsePlugin-test projects directly.
wreulicke
reviewed
Sep 8, 2020
eclipsePlugin-junit/build.gradle
Outdated
| def localProps = new Properties() | ||
| localProps.load(new FileInputStream("$rootDir/eclipsePlugin/local.properties")) | ||
|
|
||
| def eclipseRootDir = new File(localProps.getProperty('eclipseRoot.dir')) |
There was a problem hiding this comment.
Can we use file(...) instead of new File(...)?
Suggested change
| def eclipseRootDir = new File(localProps.getProperty('eclipseRoot.dir')) | |
| def eclipseRootDir = file(localProps.getProperty('eclipseRoot.dir')) |
|
Kudos, SonarCloud Quality Gate passed!
|
ThrawnCA
approved these changes
Sep 18, 2020
KengoTODA
deleted the
remove-dependencies-on-deprecated-gradle-feature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compileOnlyconfiguration is not expected to refer from other projects, so load properties file ineclipsePlugni-junitandeclipsePlugin-testprojects directly.This build scan proves that we have no deprecated feature in the current build.
Also bump up Gradle to the latest version 6.6.1.