Add note on conditional reporting of violation #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
approved these changes
Aug 9, 2020
KengoTODA
approved these changes
Aug 10, 2020
KengoTODA
added a commit
that referenced
this pull request
Aug 11, 2020
KengoTODA
added a commit
that referenced
this pull request
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per 618c4ad (change is still in place).
However one has to browse The Code to learn why such violation is not reported by default.
I expected to see this bug, but it wasn't reported on several first tries of intentionally changing inspected sources. So finally I found commit referenced above (unfortunately it does not provide reasoning for change).
Maybe the need of property is mentioned somewhere else, but I think it could also be disclosed in bug description.