Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle-mapping-metadata.xml should contain goal of spotbugs-maven-plugin #68

Closed
KengoTODA opened this issue Jun 28, 2018 · 5 comments
Labels

Comments

@KengoTODA
Copy link
Member

At here we have <goal>compile</goal>. The compile is not goal of our plugin but phase in Maven lifecycle. It should be <goal>check</goal> to run SpotBugs plugin at the timing to build.

refs https://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html

@KengoTODA KengoTODA added the bug label Jun 28, 2018
@KengoTODA
Copy link
Member Author

I'm not sure this fix is enough to link maven-spotbugs-plugin with m2e. Maybe we need some additional bridge to report detected issues in editor?

@hazendaz
Copy link
Member

I think that is likely enough. I've had luck with other plugins by defining that myself in super pom in other cases. At the very least, can you raise a PR to fix the issue?

@KengoTODA
Copy link
Member Author

YES I will.

@hazendaz
Copy link
Member

Fixed by #69. I don't think there is any need for anything more with m2e.

@hazendaz
Copy link
Member

Sorry, reopening. I thought this had been merged.

@hazendaz hazendaz reopened this Sep 18, 2018
hazendaz pushed a commit to hazendaz/spotbugs-maven-plugin that referenced this issue Sep 29, 2020
hazendaz pushed a commit to hazendaz/spotbugs-maven-plugin that referenced this issue Jan 3, 2021
hazendaz pushed a commit to hazendaz/spotbugs-maven-plugin that referenced this issue Mar 22, 2021
hazendaz pushed a commit to hazendaz/spotbugs-maven-plugin that referenced this issue Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants