Retool build depedencies to ensure proper loading #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will still pick up old where its not calling out the parent setup which is ok.
recently maven is moving away from supplying in compile scope maven artifacts. With the common filter that changed behaviour of the build here where asm was pulling 3.3.1 and not 9.3. Moved this to occur before groovy and maven artifacts as well as the bom addition to overcome these issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon maven common filter changes to stop providing extra dependencies into the build that are not needed, the behaviour of app changed to not provide proper asm when running tests. This has been retooling to ensure it works properly and for the most part (outside 2 tests) all plugins will be up to date now in the integration tests.