add multi-file support to the maven spotbugs plugin #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotbugs always supported multiple files as a comma-separated list in the <includeFilterFile> configuration option. This change also adds support for multiple files as a list: <includeFilterFiles> <includeFilterFile>...</includeFilterFile> <includeFilterFile>...</includeFilterFile> <includeFilterFiles> This allows using pom inheritance to control multiple files. Includes integration test to verify function.
Spotbugs always supported multiple files as a comma-separated list in the <excludeFilterFile> configuration option. This change also adds support for multiple files as a list: <excludeFilterFiles> <excludeFilterFile>...</excludeFilterFile> <excludeFilterFile>...</excludeFilterFile> <excludeFilterFiles> This allows using pom inheritance to control multiple files. Includes integration test to verify function.
Spotbugs always supported multiple files as a comma-separated list in the <excludeBugsFile> configuration option. This change also adds support for multiple files as a list: <excludeBugsFiles> <excludeBugsFile>...</excludeBugsFile> <excludeBugsFile>...</excludeBugsFile> <excludeBugsFiles> This allows using pom inheritance to control multiple files. As there were no integration tests for the bug baseline files, adds integration tests for - single bug exclusion file - multiple bug exclusion files, comma separated - multiple bug exclusion files as list
|
@hgschmie Thanks for this addition. This will be in 4.7.1.0 release. I'll adjust the since items separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spotbugs plugin only supports multiple files for bug inclusion, exclusion and baseline definition as comma-separated values in the single properties. This makes it very hard to use multiple sets of files in multi-module projects. One basically ends up with overriding the value in every module.
This patch adds additional list support for
<includeFilterFile>,<excludeFilterFile>and<excludeBugsFile>asThis allows the use of the maven
combine.childrensetting to dynamically control the set of files for each subproject, e.g.Main project:
Sub module A:
Sub module B:
Thus having the
globalFilterFile.xmlandmoduleAFilterFile.xmlapplied to Sub module A andglobalFilterFile.xmlandmoduleBFilterFile.xmlapplied to Sub module B.For large projects, this dramatically simplifies configuring spotbugs.
This PR contains integration tests for all the changes (and some for the filter bugs that should have been there. :-) )