Revert fix #238 and correctly handle windows as it was only handling linux type line endings #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding up with long c_ path to jar files Fix on spotbugs#238 only resulted in cleaning up unnecessary copies but made other processing worse. As a result, spotbugs#238 is being reverted. This patch is to make windows usage behave like linux usage. It still expected to copy the jar files (even if unnecessary) but not nexted into a deep folder structure, rather just the artifact name. The original logic did not handle windows at all. It now does but is still not a great solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original problem was C_ in target directory looking out of place. The change in #238 caused it to copy all resources into exact locations which under certain setup would cause source path to incorrectly be changed. After an integration test was added to confirm this, the logic was reverted here and subsequent change to handle windows in additional to linux. Now no more nested still but the add on jars like fb-contrib are copied into target. A separate ticket has been opened to address that as that seems wrong. All other copies seem appropriate.