Use file api for reading parsing artifact names, Fix #34 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkalmar
changed the title
|
@tkalmar Thanks! |
hazendaz
added a commit
to hazendaz/spotbugs-maven-plugin
that referenced
this pull request
Jan 3, 2021
hazendaz
added a commit
to hazendaz/spotbugs-maven-plugin
that referenced
this pull request
Jan 3, 2021
…ding up with long c_ path to jar files Fix on spotbugs#238 only resulted in cleaning up unnecessary copies but made other processing worse. As a result, spotbugs#238 is being reverted. This patch is to make windows usage behave like linux usage. It still expected to copy the jar files (even if unnecessary) but not nexted into a deep folder structure, rather just the artifact name. The original logic did not handle windows at all. It now does but is still not a great solution.
|
@tkalmar I had to revert this. Please see #281. I did modify support to handle windows properly as it was only working with *nix setup as originally designed. It still fixes the deeply nested c path under target but doesn't address unnecessary copying of the jar files for plugin addons (fb-contrib, etc). |
This was referenced Jan 3, 2021
hazendaz
added a commit
that referenced
this pull request
Jan 3, 2021
Revert fix #238 and correctly handle windows as it was only handling linux type line endings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THis helps loading artifacts under Windows, where separator is not '/' , Fixes #34