Loosen public suffix restriction to allow version 5.0 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
public_suffix 5.0 was just released. It includes updated definitions, and is restricted to Ruby 2.6+. Loosening this restriction allows addressable to use the latest version of public_suffix when loaded with a supported Ruby.
|
CI failures appears to be unrelated, because the same Windows/JRuby 9.3 failures are happening in this PR - #459 - as well. |
|
Change looks fine to me, no breaking API changes in |
|
Totally forgot the fact that there's a rake task to generate the gemspec 🤦 I'll update it |
dentarg
added a commit
to dentarg/addressable
that referenced
this pull request
Jul 25, 2022
I ran "bundle exec rake gem:gemspec" and this is what changed, except the date (did not change the date as I think that should reflect when releases are made). Related to sporkmonger#460 and sporkmonger#463 that both updated the generated gemspec directly. Includes the change from sporkmonger#425.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public_suffix 5.0 was just released. It includes updated definitions, and is restricted to Ruby 2.6+.
Loosening this gemspec restriction allows addressable to use the latest version of public_suffix when loaded with a supported Ruby (2.6+).