fixing missing encode component documentation entry #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…harleystran/addressable into add_missing_encode_component_doc_entry
charleystran
force-pushed
the
add_missing_encode_component_doc_entry
branch
from
52a500d
to
48a02e2
Compare
|
@sporkmonger any clue as to why the 2 jruby and truffelruby builds fail on this PR? The change is very small and I wouldnt expect it to break the builds. Any thoughts? |
|
@charleystran I guess they are unrelated. Last green build with truffleruby used 19.2.0 and the build here uses 19.3.0. Re: JRuby, Feel free to report the errors to the projects, or look into if the CI setup here can be changed in some way to make it work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the documentation to resolve #276 and add the missing docs entry for Addressable::URI.encode_component