Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Support For Node.JS 18 #31

Open
Rishi556 opened this issue Apr 1, 2023 · 3 comments
Open

Validate Support For Node.JS 18 #31

Rishi556 opened this issue Apr 1, 2023 · 3 comments
Labels
enhancement New feature or request stability

Comments

@Rishi556
Copy link
Contributor

Rishi556 commented Apr 1, 2023

Node 16 stops receiving security support in about 5 months(Sept 11 2023 https://endoflife.date/nodejs). Ensuring everything works on Node 18 before then should be done.

@vaultec81 vaultec81 added enhancement New feature or request stability labels Apr 2, 2023
@Rishi556
Copy link
Contributor Author

Rishi556 commented Apr 2, 2023

Bug on 18:

7|video  | Startup: Checking if IPFS is running
7|video  | Logged in with did:key:z6MkqEEGCJE46cqdiBf9BydAp4APDVh7RcVte9HAEeBsanmd
7|video  | IPFS Daemon Not Available. Please run IPFS.
7|video  | []

This is most likely related to IPFS not listening on [::1] for it's api and Node18 changes DNS to stop reordering to have IPv4 be first(nodejs/node#39987). An issue has been filed on Kubo's repo for this issue: ipfs/kubo#9637. Hopefully IPFS fixes the issue on their end, but we should figure out where the connecting is attempting to be made, and change it to 127.0.0.1 for now.

@vaultec81
Copy link
Member

Bug on 18:

7|video  | Startup: Checking if IPFS is running
7|video  | Logged in with did:key:z6MkqEEGCJE46cqdiBf9BydAp4APDVh7RcVte9HAEeBsanmd
7|video  | IPFS Daemon Not Available. Please run IPFS.
7|video  | []

This is most likely related to IPFS not listening on [::1] for it's api and Node18 changes DNS to stop reordering to have IPv4 be first(nodejs/node#39987). An issue has been filed on Kubo's repo for this issue: ipfs/kubo#9637. Hopefully IPFS fixes the issue on their end, but we should figure out where the connecting is attempting to be made, and change it to 127.0.0.1 for now.

We had an similar issue to this when testing PoA. Just need to explicitly set the API url to 127.0.0.1 across the entire project code base and we should be good to go. I'd say it's always better to explicitly define where it's expected to listen on rather than letting the language assume.

@Rishi556
Copy link
Contributor Author

Rishi556 commented Apr 2, 2023

Bug on 18:

7|video  | Startup: Checking if IPFS is running
7|video  | Logged in with did:key:z6MkqEEGCJE46cqdiBf9BydAp4APDVh7RcVte9HAEeBsanmd
7|video  | IPFS Daemon Not Available. Please run IPFS.
7|video  | []

This is most likely related to IPFS not listening on [::1] for it's api and Node18 changes DNS to stop reordering to have IPv4 be first(nodejs/node#39987). An issue has been filed on Kubo's repo for this issue: ipfs/kubo#9637. Hopefully IPFS fixes the issue on their end, but we should figure out where the connecting is attempting to be made, and change it to 127.0.0.1 for now.

We had an similar issue to this when testing PoA. Just need to explicitly set the API url to 127.0.0.1 across the entire project code base and we should be good to go. I'd say it's always better to explicitly define where it's expected to listen on rather than letting the language assume.

It's a simple fix by modifying the config file the for the IPFS side of things, and I'll submit a PR there after doing some testing locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stability
Projects
None yet
Development

No branches or pull requests

2 participants