Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for v2.1.0 #195

Merged
merged 2 commits into from Apr 29, 2022
Merged

Changelog for v2.1.0 #195

merged 2 commits into from Apr 29, 2022

Conversation

azdagron
Copy link
Member

Signed-off-by: Andrew Harding aharding@vmware.com

Signed-off-by: Andrew Harding <aharding@vmware.com>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just a comment about how the phrases are constructed.

CHANGELOG.md Outdated
## [2.1.0] - 2022-04-29

### Added
- Added the workloadapi.WatchX509Bundles method which watches X.509 bundles from the Workload API (#192)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't include the "Added", "Changed", etc. word to the start of the phrase, as it's already included in the title of the section.

Signed-off-by: Andrew Harding <aharding@vmware.com>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should include #191? Persons developing on Windows may be interested to know that they can consume the library on Windows platform now, so it may be good to provide visibility on that.

@azdagron
Copy link
Member Author

If I recall correctly, the library already worked on Windows. 191 just provided CI/CD pipeline support and fixed up some tests?

I'm happy to include it but I didn't originally because it didn't feel like something somebody would upgrade to this version for (since it already worked?).

@amartinezfayo
Copy link
Member

That's fair. Code changes were only on unit tests.

Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@azdagron azdagron merged commit 31de176 into spiffe:main Apr 29, 2022
@azdagron azdagron deleted the changelog-v2.1.0 branch April 29, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants