New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for v2.1.0 #195
Changelog for v2.1.0 #195
Conversation
Signed-off-by: Andrew Harding <aharding@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Just a comment about how the phrases are constructed.
CHANGELOG.md
Outdated
## [2.1.0] - 2022-04-29 | ||
|
||
### Added | ||
- Added the workloadapi.WatchX509Bundles method which watches X.509 bundles from the Workload API (#192) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't include the "Added", "Changed", etc. word to the start of the phrase, as it's already included in the title of the section.
Signed-off-by: Andrew Harding <aharding@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should include #191? Persons developing on Windows may be interested to know that they can consume the library on Windows platform now, so it may be good to provide visibility on that.
If I recall correctly, the library already worked on Windows. 191 just provided CI/CD pipeline support and fixed up some tests? I'm happy to include it but I didn't originally because it didn't feel like something somebody would upgrade to this version for (since it already worked?). |
That's fair. Code changes were only on unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Signed-off-by: Andrew Harding aharding@vmware.com