Add support for Named Pipes in Windows #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s only) Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
…s only) Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
azdagron
reviewed
Apr 13, 2022
| jwtBundlesChans: make(map[chan *workload.JWTBundlesResponse]struct{}), | ||
| } | ||
|
|
||
| listener, err := winio.ListenPipe(fmt.Sprintf(`\\.\pipe\go-spiffe-test-pipe-%x`, rand.Uint64()), nil) |
There was a problem hiding this comment.
nitpick: If we don't seed rand, then two test processes running concurrently could collide on the names :) We're more than likely ok, but just thought I'd point it out just in case.
v2/workloadapi/client_windows.go
Outdated
| // parseTargetFromNamedPipeName parses the named pipe name | ||
| // for the endpoint address and returns the target string | ||
| // suitable for dialing. | ||
| func parseTargetFromNamedPipeName(pipeName string) string { |
There was a problem hiding this comment.
nit: "parse" implies the provided arguments are being parsed, which isn't the case here. maybe rename to namedPipeTarget or makeNamedPipeTarget or something?
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
azdagron
reviewed
Apr 13, 2022
| @@ -20,6 +21,7 @@ func NewWithNamedPipeListener(tb testing.TB) *WorkloadAPI { | |||
| jwtBundlesChans: make(map[chan *workload.JWTBundlesResponse]struct{}), | |||
| } | |||
|
|
|||
| rand.Seed(time.Now().UnixNano()) | |||
There was a problem hiding this comment.
Can we do this at package init time?
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithNamedPipeNameoption, available on Windows only.