Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReDoS issue comes from d3-color version 1-2 indirect dependency! #193

Closed
dkolosov-intel opened this issue Oct 11, 2021 · 1 comment
Closed

Comments

@dkolosov-intel
Copy link

d3-flame-graph control has indirect dependency on d3-colors version 1 which has ReDoS issue(s)

The issue(s) has been fixed in d3-colors version 3

d3-selection@1.4.2 and d3-transition@1.3.2 modules have dependency on d3-color@1.4.1

+-- d3-flame-graph@4.0.6
| +-- d3-scale@3.3.0
| | +-- d3-array@2.12.1 deduped
| | +-- d3-format@1.4.5 deduped
| | +-- d3-interpolate@2.0.1
| | | -- d3-color@2.0.0 | +-- d3-selection@1.4.2 | -- d3-transition@1.3.2
| +-- d3-color@1.4.1
| +-- d3-dispatch@1.0.6 deduped
| +-- d3-ease@1.0.7 deduped
| +-- d3-interpolate@1.4.0
| | `-- d3-color@1.4.1 deduped

Please update package.json dependency block to start using d3-selection and d3-transition version 3 or next
(Ideally need to update d3 dependency modules to version 3 or next/last)

@dkolosov-intel
Copy link
Author

The upstream fix for the vulnerability is not merged yet:
d3/d3-color#89

It seems there is wrong data on a fix in d3-color>3.0.0:
d3/d3-brush#90 (comment)

It makes sense to consider this as a FALSE positive since user input is NOT used to call d3-color.
So, I am closing the issue.

(Sorry for bothering...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant