Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore case on search #144

Open
spiermar opened this issue Nov 21, 2019 · 7 comments
Open

ignore case on search #144

spiermar opened this issue Nov 21, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@spiermar
Copy link
Owner

No description provided.

@spiermar spiermar added the enhancement New feature or request label Nov 21, 2019
@rohchakr
Copy link

@spiermar I would like to work on this issue. Could you please provide more description?

@spiermar
Copy link
Owner Author

Sure @rohchakr. Should be a simple feature. Today, search is done via RegEx and is case sensitive. Having an option to ignore case on search would be beneficial.

With the current default search, if I have a frame named "Test" for example, and I type "test" on search, it would not match because of the uppercase T.

We could add an option to the chart to enable this feature and just lower the case of case of both search and frame names on comparison if enabled.

@rohchakr
Copy link

Thanks a lot.
Getting started!
Please assign this issue to me.

@rohchakr
Copy link

@spiermar Created a PR #154 for validating the approach. Please guide further.

@rohchakr
Copy link

I am thinking of having a checkbox just beside the search button to choose whether to make case-sensitive search or not.

@spiermar
Copy link
Owner Author

It could be just a library option. No need to update the examples, just document it on the README.

rohchakr added a commit to rohchakr/d3-flame-graph that referenced this issue Apr 20, 2020
Add an optional boolean argument for the function searchMatch. If the argument is true, then only the search will be case-sensitive. By default if no argument is passed during the function call, the argument will be set to false.
@rohchakr
Copy link

rohchakr commented Apr 20, 2020

@spiermar Created a new PR #155
Introduced an optional argument for the function searchMatch and made necessary updates in the readme file.
Please review.

rohchakr added a commit to rohchakr/d3-flame-graph that referenced this issue Apr 22, 2020
… - Keep default behaviour as case-sensitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants