Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand hover area on small frames #136

Open
spiermar opened this issue Aug 6, 2019 · 4 comments
Open

expand hover area on small frames #136

spiermar opened this issue Aug 6, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@spiermar
Copy link
Owner

spiermar commented Aug 6, 2019

No description provided.

@spiermar spiermar changed the title Expand hover area on small frames expand hover area on small frames Aug 19, 2019
@spiermar spiermar added the enhancement New feature or request label Aug 19, 2019
@rohchakr
Copy link

@spiermar I would like to work for this issue. Please assign this to me.

I am thinking of having a min width (if the width of any frame is smaller than this, then upon hover, its width should be set to this value). Also, would be good to have a frame border or fade effect upon hovering - this behaviour to be consistent for all frames (small and big ones).

Please share your opinion and suggest.

@spiermar
Copy link
Owner Author

This is a tricky one. Not even sure how a large hover area would work. The issue is that is impossible to read very small frames since the size of the frame is too small to hover. Having a min is not ideal since it would distort the flame graph and possibly lead to wrong assumptions during analysis. I have a minWidth option, but what it does is hiding anything smaller than that.

@rohchakr
Copy link

I see some of the small frames keep appearing as we traverse above the stack (zoom in). They are not visible once we reset zoom and go down to the previous stack level.

Provided that the content width/height remains fixed, we may not make the small frames appear. But whatever frames are visible at a particular zoom level, some styling can be applied on hover to make them focussed and stand out from the rest.

@spiermar
Copy link
Owner Author

The min size is px based, so when you zoom in, they become visible. I wouldn't worry about the non-visible frames, but the hover of visible ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants